From: Guenter Roeck <linux@roeck-us.net>
To: Nik Bune <n2h9z4@gmail.com>
Cc: krzysztof.kozlowski+dt@linaro.org, robh@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
skhan@linuxfoundation.org, wim@linux-watchdog.org
Subject: Re: [PATCH v2] dt-bindings: watchdog: qca,ar7130-wdt: convert txt to yaml
Date: Wed, 1 Nov 2023 14:03:12 -0700 [thread overview]
Message-ID: <74c8dd58-f4b8-41fa-b5da-d4e32326ffd1@roeck-us.net> (raw)
In-Reply-To: <20231101203357.48478-1-n2h9z4@gmail.com>
On 11/1/23 13:33, Nik Bune wrote:
> Changes in v2: updated commit message.
>
> v1 patch: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231031201602.28827-1-n2h9z4@gmail.com/
Unfortunately, you didn't run checkpatch on your uudate, meaning it missed
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
Indeed, your patch now provides a single-line commit description with more than
200 characters.
I don't think "Keep it in one line" was meant to ask you to do that.
The original description was substantially shorter and did fit into 75 characters.
Guenter
prev parent reply other threads:[~2023-11-01 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 20:27 [PATCH v2] dt-bindings: watchdog: qca,ar7130-wdt: convert txt to yaml Nik Bune
2023-11-01 20:33 ` Nik Bune
2023-11-01 21:03 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74c8dd58-f4b8-41fa-b5da-d4e32326ffd1@roeck-us.net \
--to=linux@roeck-us.net \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=n2h9z4@gmail.com \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).