From: Wenkai <advantech.susiteam@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: wenkai.chung@advantech.com.tw, Susi.Driver@advantech.com,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 0/5] watchdog: eiois200_wdt: Add EIO-IS200 Watchdog Driver
Date: Thu, 12 Oct 2023 15:56:52 +0800 [thread overview]
Message-ID: <6348ae7e-21f3-51ef-e60a-b3ceccc38be4@gmail.com> (raw)
In-Reply-To: <655945a4-fc45-4d01-954b-88aa6fb7231f@roeck-us.net>
Guenter Roeck 於 10/11/2023 11:05 PM 寫道:
> On Wed, Oct 11, 2023 at 12:08:57PM +0800, Wenkai wrote:
>> I understand that the patches don't meet the expected quality standards.
>> The compile issue is due to my MFD core driver, which is currently under
>> review and has not been merged yet.
>>
>> I would also like to seek your advice on how to best proceed with the
>> sub-drivers like the watchdog driver. Should I wait for my core MFD
>> driver to be successfully merged before submitting the sub-drivers, or
>> let Jones Lee review my core MFD driver and all its sub-drivers, or is
>> there another approach that you recommend?
> If the sub-drivers depend on the mfd driver, at least provide a reference
> to the patch or patch series introducing that driver. Either case, a direct
> include from "../mfd" is simply unacceptable. include/linux/mfd/ does exist
> for a reason, after all.
The LKML link is https://lkml.org/lkml/2023/9/6/1245. Is this link to
the patch
sufficient?
And, I'll move the "eiois200.h" to "include/linux/mfd/".
> I don't know the best solution for reviewing all the drivers. I didn't
> (and do not plan to) look into the driver-driver API. If the interface
> is regmap, reviewing sub-drivers on their own should be straightforward.
> If the API is with function calls, things get more complicated because
> the API needs the sub-drivers to be tested and everything needs to be
> reviewed together.
>
> Guenter
Unfortunately, all sub-drivers mostly communicate with the EC firmware
through the MFD core driver's driver-driver API, only a few uses regmap.
So should the MFD core driver and its sub-drivers be reviewed by the same
maintainers?
Best regards,
Wenkai
prev parent reply other threads:[~2023-10-12 7:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 8:51 [PATCH 0/5] watchdog: eiois200_wdt: Add EIO-IS200 Watchdog Driver advantech.susiteam
2023-10-05 8:51 ` [PATCH 1/5] watchdog: eiois200_wdt: Constructing Advantech EIO-IS200 watchdog driver advantech.susiteam
2023-10-05 23:33 ` kernel test robot
2023-10-05 8:51 ` [PATCH 2/5] watchdog: eiois200_wdt: Add PMC support with eiois200_core advantech.susiteam
2023-10-05 8:51 ` [PATCH 3/5] watchdog: eiois200_wdt: Implement basic watchdog functionalities advantech.susiteam
2023-10-05 8:51 ` [PATCH 4/5] watchdog: eiois200_wdt: Enhanced watchdog functionality and pretimeout advantech.susiteam
2023-10-05 8:51 ` [PATCH 5/5] watchdog: eiois200_wdt: Enhanced IRQ trigger behavior advantech.susiteam
2023-10-06 3:02 ` [PATCH 0/5] watchdog: eiois200_wdt: Add EIO-IS200 Watchdog Driver Guenter Roeck
2023-10-06 9:27 ` Wenkai
2023-10-06 14:16 ` Guenter Roeck
2023-10-11 4:08 ` Wenkai
2023-10-11 15:05 ` Guenter Roeck
2023-10-12 7:56 ` Wenkai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6348ae7e-21f3-51ef-e60a-b3ceccc38be4@gmail.com \
--to=advantech.susiteam@gmail.com \
--cc=Susi.Driver@advantech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wenkai.chung@advantech.com.tw \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).