From: Guenter Roeck <linux@roeck-us.net>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>
Subject: Re: [PATCH v1 3/3] watchdog: intel-mid_wdt: Get platform data via dev_get_platdata()
Date: Tue, 5 Mar 2024 09:57:42 -0800 [thread overview]
Message-ID: <47e6a7a9-e98f-43a5-a7f8-816f2277d7da@roeck-us.net> (raw)
In-Reply-To: <20240305165306.1366823-4-andriy.shevchenko@linux.intel.com>
On Tue, Mar 05, 2024 at 06:52:20PM +0200, Andy Shevchenko wrote:
> Access to platform data via dev_get_platdata() getter to make code cleaner.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/intel-mid_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
> index 06d5d207a065..8d71f6a2236b 100644
> --- a/drivers/watchdog/intel-mid_wdt.c
> +++ b/drivers/watchdog/intel-mid_wdt.c
> @@ -127,7 +127,7 @@ static int mid_wdt_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct watchdog_device *wdt_dev;
> - struct intel_mid_wdt_pdata *pdata = dev->platform_data;
> + struct intel_mid_wdt_pdata *pdata = dev_get_platdata(dev);
> struct mid_wdt *mid;
> int ret;
>
> --
> 2.43.0.rc1.1.gbec44491f096
>
prev parent reply other threads:[~2024-03-05 17:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 16:52 [PATCH v1 0/3] watchdog: intel-mid_wdt: header and code cleanups Andy Shevchenko
2024-03-05 16:52 ` [PATCH v1 1/3] watchdog: intel-mid_wdt: Remove unused intel-mid.h Andy Shevchenko
2024-03-05 17:56 ` Guenter Roeck
2024-03-05 16:52 ` [PATCH v1 2/3] watchdog: intel-mid_wdt: Don't use "proxy" headers Andy Shevchenko
2024-03-05 17:57 ` Guenter Roeck
2024-03-05 16:52 ` [PATCH v1 3/3] watchdog: intel-mid_wdt: Get platform data via dev_get_platdata() Andy Shevchenko
2024-03-05 17:57 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47e6a7a9-e98f-43a5-a7f8-816f2277d7da@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).