From: Guenter Roeck <linux@roeck-us.net>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: kernel test robot <lkp@intel.com>,
Michael Shych <michaelsh@nvidia.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: mlx_wdt: fix all kernel-doc warnings
Date: Mon, 18 Dec 2023 11:03:50 -0800 [thread overview]
Message-ID: <1c14424f-0e7f-4300-a010-3d95fbb72716@roeck-us.net> (raw)
In-Reply-To: <20231218062659.26916-1-rdunlap@infradead.org>
On 12/17/23 22:26, Randy Dunlap wrote:
> Correct kernel-doc warnings as reported by kernel test robot:
>
> mlx_wdt.c:56: warning: Function parameter or member 'wdt_type' not described in 'mlxreg_wdt'
> mlx_wdt.c:56: warning: Excess struct member 'device' description in 'mlxreg_wdt'
> mlx_wdt.c:56: warning: Excess struct member 'timeout' description in 'mlxreg_wdt'
> mlx_wdt.c:56: warning: Excess struct member 'wd_type' description in 'mlxreg_wdt'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202312171701.xNkzdgdi-lkp@intel.com/
> Cc: Michael Shych <michaelsh@nvidia.com>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-watchdog@vger.kernel.org
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/mlx_wdt.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff -- a/drivers/watchdog/mlx_wdt.c b/drivers/watchdog/mlx_wdt.c
> --- a/drivers/watchdog/mlx_wdt.c
> +++ b/drivers/watchdog/mlx_wdt.c
> @@ -30,17 +30,15 @@
> * struct mlxreg_wdt - wd private data:
> *
> * @wdd: watchdog device;
> - * @device: basic device;
> * @pdata: data received from platform driver;
> * @regmap: register map of parent device;
> - * @timeout: defined timeout in sec.;
> * @action_idx: index for direct access to action register;
> * @timeout_idx:index for direct access to TO register;
> * @tleft_idx: index for direct access to time left register;
> * @ping_idx: index for direct access to ping register;
> * @reset_idx: index for direct access to reset cause register;
> * @regmap_val_sz: size of value in register map;
> - * @wd_type: watchdog HW type;
> + * @wdt_type: watchdog HW type;
> */
> struct mlxreg_wdt {
> struct watchdog_device wdd;
>
prev parent reply other threads:[~2023-12-18 19:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 6:26 [PATCH] watchdog: mlx_wdt: fix all kernel-doc warnings Randy Dunlap
2023-12-18 19:03 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c14424f-0e7f-4300-a010-3d95fbb72716@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=lkp@intel.com \
--cc=michaelsh@nvidia.com \
--cc=rdunlap@infradead.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).