From: Guenter Roeck <linux@roeck-us.net>
To: Jerry Hoemann <jerry.hoemann@hpe.com>
Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] watchdog/hpwdt: Remove unused variable
Date: Wed, 13 Dec 2023 14:14:32 -0800 [thread overview]
Message-ID: <1912161e-eb33-47dd-a458-b2c6179fc647@roeck-us.net> (raw)
In-Reply-To: <20231213215340.495734-4-jerry.hoemann@hpe.com>
On Wed, Dec 13, 2023 at 02:53:40PM -0700, Jerry Hoemann wrote:
> Remove the unused variable ilo5.
>
> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/hpwdt.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> index d5c0aa3ef069..138dc8d8ca3d 100644
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -33,7 +33,6 @@
> #define DEFAULT_MARGIN 30
> #define PRETIMEOUT_SEC 9
>
> -static bool ilo5;
> static unsigned int soft_margin = DEFAULT_MARGIN; /* in seconds */
> static bool nowayout = WATCHDOG_NOWAYOUT;
> static bool pretimeout = IS_ENABLED(CONFIG_HPWDT_NMI_DECODING);
> @@ -360,9 +359,6 @@ static int hpwdt_init_one(struct pci_dev *dev,
> pretimeout ? "on" : "off");
> dev_info(&dev->dev, "kdumptimeout: %d.\n", kdumptimeout);
>
> - if (dev->subsystem_vendor == PCI_VENDOR_ID_HP_3PAR)
> - ilo5 = true;
> -
> return 0;
>
> error_wd_register:
> --
> 2.41.0
>
prev parent reply other threads:[~2023-12-13 22:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 21:53 [PATCH v2 0/3] watchdog/hpwdt: Cleanup Claiming NMI Jerry Hoemann
2023-12-13 21:53 ` [PATCH v2 1/3] watchdog/hpwdt: Only claim UNKNOWN NMI if from iLO Jerry Hoemann
2023-12-13 22:14 ` Guenter Roeck
2023-12-13 21:53 ` [PATCH v2 2/3] watchdog/hpwdt: Remove redundant test Jerry Hoemann
2023-12-13 22:14 ` Guenter Roeck
2023-12-13 21:53 ` [PATCH v2 3/3] watchdog/hpwdt: Remove unused variable Jerry Hoemann
2023-12-13 22:14 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1912161e-eb33-47dd-a458-b2c6179fc647@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jerry.hoemann@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).