From: "Ondřej Jirman" <megi@xff.cz>
To: Amit Sunil Dhamne <amitsd@google.com>
Cc: linux@roeck-us.net, heikki.krogerus@linux.intel.com,
gregkh@linuxfoundation.org, badhri@google.com,
rdbabiera@google.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v1] usb: typec: tcpm: fix use-after-free case in tcpm_register_source_caps
Date: Wed, 15 May 2024 01:00:02 +0200 [thread overview]
Message-ID: <b5dv5qmijibyhqsgcv5mcdr2m2sig5hlu2vqsual5rzszl7472@gznxkm3nztbx> (raw)
In-Reply-To: <20240514220134.2143181-1-amitsd@google.com>
On Tue, May 14, 2024 at 03:01:31PM GMT, Amit Sunil Dhamne wrote:
> There could be a potential use-after-free case in
> tcpm_register_source_caps(). This could happen when:
> * new (say invalid) source caps are advertised
> * the existing source caps are unregistered
> * tcpm_register_source_caps() returns with an error as
> usb_power_delivery_register_capabilities() fails
>
> This causes port->partner_source_caps to hold on to the now freed source
> caps.
>
> Reset port->partner_source_caps value to NULL after unregistering
> existing source caps.
>
> Fixes: 230ecdf71a64 ("usb: typec: tcpm: unregister existing source caps before re-registration")
> Cc: stable@vger.kernel.org
> Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
>
Reviewed-by: Ondrej Jirman <megi@xff.cz>
Thanks for the fix.
Kind regards,
o.
>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 8a1af08f71b6..be4127ef84e9 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -3014,8 +3014,10 @@ static int tcpm_register_source_caps(struct tcpm_port *port)
> memcpy(caps.pdo, port->source_caps, sizeof(u32) * port->nr_source_caps);
> caps.role = TYPEC_SOURCE;
>
> - if (cap)
> + if (cap) {
> usb_power_delivery_unregister_capabilities(cap);
> + port->partner_source_caps = NULL;
> + }
>
> cap = usb_power_delivery_register_capabilities(port->partner_pd, &caps);
> if (IS_ERR(cap))
>
> base-commit: 51474ab44abf907023a8a875e799b07de461e466
> --
> 2.45.0.rc1.225.g2a3ae87e7f-goog
>
next prev parent reply other threads:[~2024-05-14 23:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 22:01 [PATCH v1] usb: typec: tcpm: fix use-after-free case in tcpm_register_source_caps Amit Sunil Dhamne
2024-05-14 23:00 ` Ondřej Jirman [this message]
2024-05-19 8:00 ` Dmitry Baryshkov
2024-05-21 13:53 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5dv5qmijibyhqsgcv5mcdr2m2sig5hlu2vqsual5rzszl7472@gznxkm3nztbx \
--to=megi@xff.cz \
--cc=amitsd@google.com \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rdbabiera@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).