* Re: [PATCH v2] usb: Improves USB2.0 write performance
[not found] <CABd4UjYSaZv6H9Q-UbM8QQZk8HcBPrJ7=DfDQGxJNVNot68Kfg@mail.gmail.com>
@ 2022-08-29 8:59 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2022-08-29 8:59 UTC (permalink / raw
To: Hu Xiaoying; +Cc: usb-storage, linux-usb, stern
On Mon, Aug 29, 2022 at 04:52:36PM +0800, Hu Xiaoying wrote:
> >From ad9e714341bbc944d4b8868229f15622592f37d5 Mon Sep 17 00:00:00 2001
> From: Hu Xiaoying <huxiaoying@gmail.com>
> Date: Wed, 22 Jun 2022 16:35:59 +0800
> Subject: [PATCH] usb: Improves USB2.0 write performance
>
> USB external storage device(0x0b05:1932), use gnome-disk-utility tools
> to test usb write < 30MB/s.
> Then, igoned to load module of uas for this device.
> ===============================================
> Write speed: Improves form 27MB/s to 40MB/s+
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Hu Xiaoying <huxiaoying@gmail.com>
> ---
> drivers/usb/storage/unusual_uas.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/storage/unusual_uas.h
> b/drivers/usb/storage/unusual_uas.h
> index 4051c8cd0cd8..abaf4ea8138b 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -157,3 +157,10 @@ UNUSUAL_DEV(0x4971, 0x8024, 0x0000, 0x9999,
> "External HDD",
> USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> US_FL_ALWAYS_SYNC),
> +
> +/* Reported-by: Tom Hu <huxiaoying@gmail.com> */
> +UNUSUAL_DEV(0x0b05, 0x1932, 0x0000, 0x9999,
> + "ASUS",
> + "External HDD",
> + USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> + US_FL_IGNORE_UAS),
> --
> 2.25.1
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch was attached, please place it inline so that it can be
applied directly from the email message itself.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what a proper Subject: line should
look like.
- It looks like you did not use your "real" name for the patch on either
the Signed-off-by: line, or the From: line (both of which have to
match). Please read the kernel file, Documentation/SubmittingPatches
for how to do this correctly.
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for what needs to be done
here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] usb: Improves USB2.0 write performance
[not found] <CABd4UjYS4QDozv-RKp3_9XhQec=LO+z9U8+=Oa8=MEFyaeXYhA@mail.gmail.com>
@ 2022-08-29 9:04 ` Greg KH
2022-08-29 13:56 ` Alan Stern
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2022-08-29 9:04 UTC (permalink / raw
To: Hu Xiaoying; +Cc: usb-storage, linux-usb, stern
On Mon, Aug 29, 2022 at 04:58:57PM +0800, Hu Xiaoying wrote:
> From: Hu Xiaoying <huxiaoying@gmail.com>
<snip>
You can not send html mail to the mailing lists, for patches, it will be
rejected and does not work at all.
Please read the kernel documentation about dealing with email clients.
Also, the above "From:" line does not match your "From:" line on the
email, causing me to automatically reject the submission for obvious
reasons.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] usb: Improves USB2.0 write performance
[not found] <CABd4UjYS4QDozv-RKp3_9XhQec=LO+z9U8+=Oa8=MEFyaeXYhA@mail.gmail.com>
2022-08-29 9:04 ` [PATCH v2] usb: Improves USB2.0 write performance Greg KH
@ 2022-08-29 13:56 ` Alan Stern
1 sibling, 0 replies; 3+ messages in thread
From: Alan Stern @ 2022-08-29 13:56 UTC (permalink / raw
To: Hu Xiaoying; +Cc: usb-storage, linux-usb, gregkh
On Mon, Aug 29, 2022 at 04:58:57PM +0800, Hu Xiaoying wrote:
> From: Hu Xiaoying <huxiaoying@gmail.com>
>
> USB external storage device(0x0b05:1932), use gnome-disk-utility tools
> to test usb write < 30MB/s.
> Then, igoned to load module of uas for this device.
--------^^^^^^
"igoned" is not a word in English.
> ===============================================
Why did you put this line here?
> Write speed: Improves form 27MB/s to 40MB/s+
------------------------^^^^
---------------------------------------^^^^^^^
"from", not "form".
"> 40MB/s", not "40MB/s+".
>
> Signed-off-by: Hu Xiaoying <huxiaoying@gmail.com>
> ---
> drivers/usb/storage/unusual_uas.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/storage/unusual_uas.h
> b/drivers/usb/storage/unusual_uas.h
> index 4051c8cd0cd8..abaf4ea8138b 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -157,3 +157,10 @@ UNUSUAL_DEV(0x4971, 0x8024, 0x0000, 0x9999,
> "External HDD",
> USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> US_FL_ALWAYS_SYNC),
> +
> +/* Reported-by: Tom Hu <huxiaoying@gmail.com> */
> +UNUSUAL_DEV(0x0b05, 0x1932, 0x0000, 0x9999,
> + "ASUS",
> + "External HDD",
> + USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> + US_FL_IGNORE_UAS),
Entries should be sorted by vendor ID and product ID. This entry is
added in the wrong place (0x0b05 comes before 0x4971, not after).
Alan Stern
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-29 13:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CABd4UjYS4QDozv-RKp3_9XhQec=LO+z9U8+=Oa8=MEFyaeXYhA@mail.gmail.com>
2022-08-29 9:04 ` [PATCH v2] usb: Improves USB2.0 write performance Greg KH
2022-08-29 13:56 ` Alan Stern
[not found] <CABd4UjYSaZv6H9Q-UbM8QQZk8HcBPrJ7=DfDQGxJNVNot68Kfg@mail.gmail.com>
2022-08-29 8:59 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).