From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: usb: uhci: convert to dt schema
Date: Tue, 23 Apr 2024 10:39:54 +0200 [thread overview]
Message-ID: <5d8f8c79-5343-46b3-b706-e3eb541c6851@kernel.org> (raw)
In-Reply-To: <a97420fc-1fc3-4e85-9539-e1a74c711be0@gmail.com>
On 23/04/2024 09:54, Mohammad Shehar Yaar Tausif wrote:
> On 4/23/24 12:24 PM, Krzysztof Kozlowski wrote:
>> On 22/04/2024 14:21, Mohammad Shehar Yaar Tausif wrote:
>>> Convert USB UHCI bindings to DT schema. Documenting aspeed compatibles
>>> and missing properties. Adding aspeed/generic-uhci example and fix previous
>>> incorrect example.
>>>
>>> Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
>>
>>> +required:
>>> + - compatible
>>> + - reg
>>> + - interrupts
>>> +
>>> +allOf:
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + const: generic-uhci
>>> + then:
>>> + $ref: usb-hcd.yaml
>>
>> Nothing improved here.
>
> Sorry, I could not understand this, please guide me about the correction
> required here.
> I added $ref inside the if-then block because it was raising errors when
> tested against
> dts files that used "platform-uhci" as the compatible. Putting it above
> the if block did
> not work.
Where is it explained? The answer to such problem is not make bindings
incorrect... I mean, the easiest to understand if you are doing
something unusual is to check if you see such pattern. How many bindings
reference other schema in if:then:? Is this common?
>
> When I ref the usb-hcd.yaml, it also includes usb.yaml which requires
> the nodename to start with usb*,
Yeah, because DTS should be fixed, not bindings made incorrect.
> but the dtsi that use the deprecated compatible
> (arch/arm/boot/dts/vt8500/wm8505.dtsi) have their nodename with
> uhci*, which causes the tests to fail.
So fix the DTS.
>
>>> + required:
>>> + - clocks
>>
>> And this was not tested.
>>> +
>>> +unevaluatedProperties: false
>>> +
>>> +examples:
>>> + - |
>>> + uhci@d8007b00 {
>>> + compatible = "platform-uhci";
>>
>> What happened here? This is deprecated!
>
> The original example has the nodename as uhci* which causes the schema
> to fail as mentioned earlier.
So the solution is to correct the name, not use deprecated compatible
and incorrect name.
> Should I just remove the example or should I rename the node here and
> add clock field to the original example ?
I assume you understand the concept of bindings and went briefly through
DT specification or some tutorials. So yes, you must fix the node name.
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
prev parent reply other threads:[~2024-04-23 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 12:21 [PATCH v3] dt-bindings: usb: uhci: convert to dt schema Mohammad Shehar Yaar Tausif
2024-04-23 6:54 ` Krzysztof Kozlowski
2024-04-23 7:54 ` Mohammad Shehar Yaar Tausif
2024-04-23 8:39 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d8f8c79-5343-46b3-b706-e3eb541c6851@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sheharyaar48@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).