Linux-USB Archive mirror
 help / color / mirror / Atom feed
* [PATCH v5 0/6] Fix USB pipe configuration for RZ/G2L
@ 2024-03-19 10:53 Biju Das
  2024-03-19 10:53 ` [PATCH v5 1/6] dt-bindings: usb: renesas,usbhs: Document RZ/G2L family compatible Biju Das
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Biju Das @ 2024-03-19 10:53 UTC (permalink / raw
  To: Rob Herring, Krzysztof Kozlowski, Greg Kroah-Hartman,
	Conor Dooley
  Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, Yoshihiro Shimoda,
	linux-usb, devicetree, linux-renesas-soc, Prabhakar Mahadev Lad,
	Biju Das

The USBHS IP found on RZ/G2L SoCs only has 10 pipe buffers compared
to 16 pipe buffers on RZ/A2M. Document renesas,rzg2l-usbhs family
compatible to handle this difference for RZ/G2L family SoCs.

This patch series aims to fix the USB pipe configuration for RZ/G2L
family SoCs.

For the backward compatibility SoC specific compatible is used
and will be removed the same after few kernel releases.

As the DTS update has a hard dependency on the driver fix, Got ack
from Geert for patch#6 to apply the DTS update together with the driver
fix.

v4->v5:
 * Restored the else path for has_new_pipe_configs check in usbhs_probe().
v3->v4:
 * Added Rbtag from Geert for patch#3.
 * Dropped patch#4
 * Credit  Huy Nguyen's work in the commit message for patch#4 and dropped
   his name from Signed-off-by tag.
 * Selection of usbhsc_rzg2l_default_pipe[] by setting the variable
   has_new_pipe_configs to zero.
 * Updated commit description for patch#4.
 * Dropped the check 'priv->dparam.pipe_configs' as it is same as
   checking !has_new_pipe_configs.
v2->v3:
 * Added Rb tag from Geert for patch#1,#2 and #7
 * Added Ack tag from Geert for patch#7.
 * Added patch#3 for improving usbhsc_default_pipe[] for isochronous
   transfers
 * Added patch#4 for dropping has_new_pipe_configs from struct
   renesas_usbhs_driver_param
 * Updated commit description for patch#5
 * Dropped usbhsc_rzg2l_pipe[] and reusing the default_pipe[].
v1->v2:
 * Added Ack from Krzysztof Kozlowski for patch#1.
 * Added patch#2 for simplify obtaining device data.
 * Dropped using of_device_is_compatible() in probe.
 * Added usbhs_rzg2l_plat_info and replaced the device data for RZ/G2L
   from usbhs_rza2_plat_info->usbhs_rzg2l_plat_info.
 * Moved usbhsc_rzg2l_pipe table near to the user.
 * Updated commit description in patch#3
 * Added Rb tag from Geert for patch#4.
 * Updated commit description about ABI breakage in patch#5.
 * Updated commit header in patch#5 as it is RZ/G2L specific.

Biju Das (6):
  dt-bindings: usb: renesas,usbhs: Document RZ/G2L family compatible
  usb: renesas_usbhs: Simplify obtaining device data
  usb: renesas_usbhs: Improve usbhsc_default_pipe[] for isochronous
    transfers
  usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family
  usb: renesas_usbhs: Remove trailing comma in the terminator entry for
    OF table
  arm64: dts: renesas: r9a07g0{43,44,54}: Update RZ/G2L family
    compatible

 .../bindings/usb/renesas,usbhs.yaml           |  6 ++-
 arch/arm64/boot/dts/renesas/r9a07g043.dtsi    |  2 +-
 arch/arm64/boot/dts/renesas/r9a07g044.dtsi    |  2 +-
 arch/arm64/boot/dts/renesas/r9a07g054.dtsi    |  2 +-
 drivers/usb/renesas_usbhs/common.c            | 41 ++++++++++++-------
 drivers/usb/renesas_usbhs/rza.h               |  1 +
 drivers/usb/renesas_usbhs/rza2.c              | 13 ++++++
 7 files changed, 48 insertions(+), 19 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v5 1/6] dt-bindings: usb: renesas,usbhs: Document RZ/G2L family compatible
  2024-03-19 10:53 [PATCH v5 0/6] Fix USB pipe configuration for RZ/G2L Biju Das
@ 2024-03-19 10:53 ` Biju Das
  2024-03-19 10:53 ` [PATCH v5 2/6] usb: renesas_usbhs: Simplify obtaining device data Biju Das
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Biju Das @ 2024-03-19 10:53 UTC (permalink / raw
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: Biju Das, Greg Kroah-Hartman, Geert Uytterhoeven, Magnus Damm,
	Yoshihiro Shimoda, linux-usb, devicetree, linux-renesas-soc,
	Prabhakar Mahadev Lad, Biju Das, Krzysztof Kozlowski

The USBHS IP found on RZ/G2L SoCs only has 10 pipe buffers compared
to 16 pipe buffers on RZ/A2M. Document renesas,rzg2l-usbhs family
compatible to handle this difference for RZ/G2L family SoCs.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v4->v5:
 * No change.
v3->v4:
 * No change.
v2->v3:
 * Added Rb tag from Geert.
v1->v2:
 * Added Ack from Krzysztof Kozlowski.
---
 Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
index 40ada78f2328..c63db3ebd07b 100644
--- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
+++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
@@ -19,10 +19,14 @@ properties:
       - items:
           - enum:
               - renesas,usbhs-r7s9210   # RZ/A2
+          - const: renesas,rza2-usbhs
+
+      - items:
+          - enum:
               - renesas,usbhs-r9a07g043 # RZ/G2UL and RZ/Five
               - renesas,usbhs-r9a07g044 # RZ/G2{L,LC}
               - renesas,usbhs-r9a07g054 # RZ/V2L
-          - const: renesas,rza2-usbhs
+          - const: renesas,rzg2l-usbhs
 
       - items:
           - enum:
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v5 2/6] usb: renesas_usbhs: Simplify obtaining device data
  2024-03-19 10:53 [PATCH v5 0/6] Fix USB pipe configuration for RZ/G2L Biju Das
  2024-03-19 10:53 ` [PATCH v5 1/6] dt-bindings: usb: renesas,usbhs: Document RZ/G2L family compatible Biju Das
@ 2024-03-19 10:53 ` Biju Das
  2024-03-19 10:53 ` [PATCH v5 3/6] usb: renesas_usbhs: Improve usbhsc_default_pipe[] for isochronous transfers Biju Das
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Biju Das @ 2024-03-19 10:53 UTC (permalink / raw
  To: Greg Kroah-Hartman
  Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, Rob Herring,
	Yoshihiro Shimoda, Krzysztof Kozlowski, Uwe Kleine-König,
	linux-usb, linux-renesas-soc, Prabhakar Mahadev Lad, Biju Das

Simplify probe() by removing redundant dev->of_node check.

While at it, replace dev_err->dev_err_probe for error path.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v4->v5:
 * No change.
v3->v4:
 * No change.
v2->v3:
 * Added Rb tag from Geert.
v2:
 * New patch.
---
 drivers/usb/renesas_usbhs/common.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index dd1c17542439..0c62e4c6c88d 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -595,16 +595,11 @@ static int usbhs_probe(struct platform_device *pdev)
 	u32 tmp;
 	int irq;
 
-	/* check device node */
-	if (dev_of_node(dev))
-		info = of_device_get_match_data(dev);
-	else
-		info = renesas_usbhs_get_info(pdev);
-
-	/* check platform information */
+	info = of_device_get_match_data(dev);
 	if (!info) {
-		dev_err(dev, "no platform information\n");
-		return -EINVAL;
+		info = renesas_usbhs_get_info(pdev);
+		if (!info)
+			return dev_err_probe(dev, -EINVAL, "no platform info\n");
 	}
 
 	/* platform data */
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v5 3/6] usb: renesas_usbhs: Improve usbhsc_default_pipe[] for isochronous transfers
  2024-03-19 10:53 [PATCH v5 0/6] Fix USB pipe configuration for RZ/G2L Biju Das
  2024-03-19 10:53 ` [PATCH v5 1/6] dt-bindings: usb: renesas,usbhs: Document RZ/G2L family compatible Biju Das
  2024-03-19 10:53 ` [PATCH v5 2/6] usb: renesas_usbhs: Simplify obtaining device data Biju Das
@ 2024-03-19 10:53 ` Biju Das
  2024-03-19 10:53 ` [PATCH v5 4/6] usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family Biju Das
  2024-03-19 10:53 ` [PATCH v5 5/6] usb: renesas_usbhs: Remove trailing comma in the terminator entry for OF table Biju Das
  4 siblings, 0 replies; 7+ messages in thread
From: Biju Das @ 2024-03-19 10:53 UTC (permalink / raw
  To: Greg Kroah-Hartman
  Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, Rob Herring,
	Yoshihiro Shimoda, Krzysztof Kozlowski, Uwe Kleine-König,
	linux-usb, linux-renesas-soc, Prabhakar Mahadev Lad, Biju Das

As per the hardware manual, double buffer setting results in fewer
interrupts for high-speed data transfers. Improve usbhsc_default_pipe[]
for isochronous transfers by updating the table from single->double
buffering and update the pipe number accordingly.

Suggested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v4->v5:
 * No change
v3->v4:
 * Added Rbtag from Geert.
v3:
 * New patch
---
 drivers/usb/renesas_usbhs/common.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index 0c62e4c6c88d..177fa3144a47 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -366,11 +366,11 @@ static void usbhsc_clk_disable_unprepare(struct usbhs_priv *priv)
 /* commonly used on old SH-Mobile SoCs */
 static struct renesas_usbhs_driver_pipe_config usbhsc_default_pipe[] = {
 	RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_CONTROL, 64, 0x00, false),
-	RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_ISOC, 1024, 0x08, false),
-	RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_ISOC, 1024, 0x18, false),
-	RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_BULK, 512, 0x28, true),
-	RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_BULK, 512, 0x38, true),
+	RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_ISOC, 1024, 0x08, true),
+	RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_ISOC, 1024, 0x28, true),
 	RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_BULK, 512, 0x48, true),
+	RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_BULK, 512, 0x58, true),
+	RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_BULK, 512, 0x68, true),
 	RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_INT, 64, 0x04, false),
 	RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_INT, 64, 0x05, false),
 	RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_INT, 64, 0x06, false),
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v5 4/6] usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family
  2024-03-19 10:53 [PATCH v5 0/6] Fix USB pipe configuration for RZ/G2L Biju Das
                   ` (2 preceding siblings ...)
  2024-03-19 10:53 ` [PATCH v5 3/6] usb: renesas_usbhs: Improve usbhsc_default_pipe[] for isochronous transfers Biju Das
@ 2024-03-19 10:53 ` Biju Das
  2024-03-19 11:24   ` Geert Uytterhoeven
  2024-03-19 10:53 ` [PATCH v5 5/6] usb: renesas_usbhs: Remove trailing comma in the terminator entry for OF table Biju Das
  4 siblings, 1 reply; 7+ messages in thread
From: Biju Das @ 2024-03-19 10:53 UTC (permalink / raw
  To: Greg Kroah-Hartman
  Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, Huy Nguyen,
	Rob Herring, Yoshihiro Shimoda, Krzysztof Kozlowski,
	Uwe Kleine-König, linux-usb, linux-renesas-soc,
	Prabhakar Mahadev Lad, Biju Das

The RZ/G2L family SoCs has 10 pipe buffers compared to 16 pipe buffers on
RZ/A2M. Update the pipe configuration for RZ/G2L family SoCs and use
family SoC specific compatible to handle this difference.

The pipe configuration of RZ/G2L is same as usbhsc_rzg2l_default_pipe[],
so select the default pipe configuration for RZ/G2L SoCs by setting
.has_new_pipe_configs to zero.

Add SoC specific compatible to OF table to avoid ABI breakage with old
DTB. To optimize memory usage the SoC specific compatible will be removed
later.

Based on the patch in BSP by Huy Nguyen <huy.nguyen.wh@renesas.com>

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v4->v5:
 * Restored the else path for has_new_pipe_configs check in usbhs_probe().
v3->v4:
 * Credit  Huy Nguyen's work in the commit message and dropped his name
   from Signed-off-by tag.
 * Selection of usbhsc_rzg2l_default_pipe[] by setting the variable
   has_new_pipe_configs to zero.
 * Updated commit description.
 * Dropped the check 'priv->dparam.pipe_configs' as it is same as
   checking !has_new_pipe_configs.
v2->v3:
 * Updated commit description
 * Dropped usbhsc_rzg2l_pipe[] and reusing the default_pipe[].
v1->v2:
 * Dropped using of_device_is_compatible() in probe.
 * Added usbhs_rzg2l_plat_info and replaced the device data for RZ/G2L
   from usbhs_rza2_plat_info->usbhs_rzg2l_plat_info.
 * Moved usbhsc_rzg2l_pipe table near to the user.
 * Updated commit description.
---
 drivers/usb/renesas_usbhs/common.c | 18 +++++++++++++++++-
 drivers/usb/renesas_usbhs/rza.h    |  1 +
 drivers/usb/renesas_usbhs/rza2.c   | 13 +++++++++++++
 3 files changed, 31 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index 177fa3144a47..b436927c2711 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -363,7 +363,7 @@ static void usbhsc_clk_disable_unprepare(struct usbhs_priv *priv)
  *		platform default param
  */
 
-/* commonly used on old SH-Mobile SoCs */
+/* commonly used on old SH-Mobile and RZ/G2L family SoCs */
 static struct renesas_usbhs_driver_pipe_config usbhsc_default_pipe[] = {
 	RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_CONTROL, 64, 0x00, false),
 	RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_ISOC, 1024, 0x08, true),
@@ -565,6 +565,18 @@ static const struct of_device_id usbhs_of_match[] = {
 		.compatible = "renesas,usbhs-r8a77995",
 		.data = &usbhs_rcar_gen3_with_pll_plat_info,
 	},
+	{
+		.compatible = "renesas,usbhs-r9a07g043",
+		.data = &usbhs_rzg2l_plat_info,
+	},
+	{
+		.compatible = "renesas,usbhs-r9a07g044",
+		.data = &usbhs_rzg2l_plat_info,
+	},
+	{
+		.compatible = "renesas,usbhs-r9a07g054",
+		.data = &usbhs_rzg2l_plat_info,
+	},
 	{
 		.compatible = "renesas,rcar-gen2-usbhs",
 		.data = &usbhs_rcar_gen2_plat_info,
@@ -581,6 +593,10 @@ static const struct of_device_id usbhs_of_match[] = {
 		.compatible = "renesas,rza2-usbhs",
 		.data = &usbhs_rza2_plat_info,
 	},
+	{
+		.compatible = "renesas,rzg2l-usbhs",
+		.data = &usbhs_rzg2l_plat_info,
+	},
 	{ },
 };
 MODULE_DEVICE_TABLE(of, usbhs_of_match);
diff --git a/drivers/usb/renesas_usbhs/rza.h b/drivers/usb/renesas_usbhs/rza.h
index a29b75fef057..8b879aa34a20 100644
--- a/drivers/usb/renesas_usbhs/rza.h
+++ b/drivers/usb/renesas_usbhs/rza.h
@@ -3,3 +3,4 @@
 
 extern const struct renesas_usbhs_platform_info usbhs_rza1_plat_info;
 extern const struct renesas_usbhs_platform_info usbhs_rza2_plat_info;
+extern const struct renesas_usbhs_platform_info usbhs_rzg2l_plat_info;
diff --git a/drivers/usb/renesas_usbhs/rza2.c b/drivers/usb/renesas_usbhs/rza2.c
index f079817250bb..b83699eab373 100644
--- a/drivers/usb/renesas_usbhs/rza2.c
+++ b/drivers/usb/renesas_usbhs/rza2.c
@@ -71,3 +71,16 @@ const struct renesas_usbhs_platform_info usbhs_rza2_plat_info = {
 		.has_new_pipe_configs = 1,
 	},
 };
+
+const struct renesas_usbhs_platform_info usbhs_rzg2l_plat_info = {
+	.platform_callback = {
+		.hardware_init = usbhs_rza2_hardware_init,
+		.hardware_exit = usbhs_rza2_hardware_exit,
+		.power_ctrl = usbhs_rza2_power_ctrl,
+		.get_id = usbhs_get_id_as_gadget,
+	},
+	.driver_param = {
+		.has_cnen = 1,
+		.cfifo_byte_addr = 1,
+	},
+};
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v5 5/6] usb: renesas_usbhs: Remove trailing comma in the terminator entry for OF table
  2024-03-19 10:53 [PATCH v5 0/6] Fix USB pipe configuration for RZ/G2L Biju Das
                   ` (3 preceding siblings ...)
  2024-03-19 10:53 ` [PATCH v5 4/6] usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family Biju Das
@ 2024-03-19 10:53 ` Biju Das
  4 siblings, 0 replies; 7+ messages in thread
From: Biju Das @ 2024-03-19 10:53 UTC (permalink / raw
  To: Greg Kroah-Hartman
  Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, Huy Nguyen,
	Rob Herring, Yoshihiro Shimoda, Krzysztof Kozlowski,
	Uwe Kleine-König, linux-usb, linux-renesas-soc,
	Prabhakar Mahadev Lad, Biju Das

Remove the trailing comma in the terminator entry for the OF table
making code robust against (theoretical) misrebases or other similar
things where the new entry goes _after_ the termination without the
compiler noticing.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v4->v5:
 * No change.
v3->v4:
 * No change.
v2->v3:
 * No change.
v1->v2:
 * Added Rb tag from Geert.
---
 drivers/usb/renesas_usbhs/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index b436927c2711..b6bef9081bf2 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -597,7 +597,7 @@ static const struct of_device_id usbhs_of_match[] = {
 		.compatible = "renesas,rzg2l-usbhs",
 		.data = &usbhs_rzg2l_plat_info,
 	},
-	{ },
+	{ }
 };
 MODULE_DEVICE_TABLE(of, usbhs_of_match);
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v5 4/6] usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family
  2024-03-19 10:53 ` [PATCH v5 4/6] usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family Biju Das
@ 2024-03-19 11:24   ` Geert Uytterhoeven
  0 siblings, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2024-03-19 11:24 UTC (permalink / raw
  To: Biju Das
  Cc: Greg Kroah-Hartman, Geert Uytterhoeven, Magnus Damm, Huy Nguyen,
	Rob Herring, Yoshihiro Shimoda, Krzysztof Kozlowski,
	Uwe Kleine-König, linux-usb, linux-renesas-soc,
	Prabhakar Mahadev Lad, Biju Das

On Tue, Mar 19, 2024 at 11:54 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> The RZ/G2L family SoCs has 10 pipe buffers compared to 16 pipe buffers on
> RZ/A2M. Update the pipe configuration for RZ/G2L family SoCs and use
> family SoC specific compatible to handle this difference.
>
> The pipe configuration of RZ/G2L is same as usbhsc_rzg2l_default_pipe[],
> so select the default pipe configuration for RZ/G2L SoCs by setting
> .has_new_pipe_configs to zero.
>
> Add SoC specific compatible to OF table to avoid ABI breakage with old
> DTB. To optimize memory usage the SoC specific compatible will be removed
> later.
>
> Based on the patch in BSP by Huy Nguyen <huy.nguyen.wh@renesas.com>
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v4->v5:
>  * Restored the else path for has_new_pipe_configs check in usbhs_probe().

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-03-19 11:25 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-19 10:53 [PATCH v5 0/6] Fix USB pipe configuration for RZ/G2L Biju Das
2024-03-19 10:53 ` [PATCH v5 1/6] dt-bindings: usb: renesas,usbhs: Document RZ/G2L family compatible Biju Das
2024-03-19 10:53 ` [PATCH v5 2/6] usb: renesas_usbhs: Simplify obtaining device data Biju Das
2024-03-19 10:53 ` [PATCH v5 3/6] usb: renesas_usbhs: Improve usbhsc_default_pipe[] for isochronous transfers Biju Das
2024-03-19 10:53 ` [PATCH v5 4/6] usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family Biju Das
2024-03-19 11:24   ` Geert Uytterhoeven
2024-03-19 10:53 ` [PATCH v5 5/6] usb: renesas_usbhs: Remove trailing comma in the terminator entry for OF table Biju Das

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).