* [PATCH v2] dt-bindings: usb: samsung,exynos-dwc3: allow unit address in DTS
@ 2023-01-27 21:17 Krzysztof Kozlowski
2023-01-30 21:22 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-27 21:17 UTC (permalink / raw
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
linux-usb, devicetree, linux-arm-kernel, linux-samsung-soc,
linux-kernel
Cc: replicant, phone-devel, ~postmarketos/upstreaming,
Martin Jücker, Henrik Grimler, Sam Protsenko, Chanho Park,
Marek Szyprowski, Chanwoo Choi, Krzysztof Kozlowski
The Samsung Exynos SoC USB 3.0 DWC3 Controller is a simple wrapper of
actual DWC3 Controller device node. It handles necessary Samsung
Exynos-specific resources (regulators, clocks), but does not have its
own MMIO address space.
However neither simple-bus bindings nor dtc W=1 accept device nodes in
soc@ node which do not have unit address.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes since v1:
1. Use ranges with values and drop reg from usb-wrapper node.
2. Keep "usb" as wrapper's node name.
DTS fixes are here:
https://lore.kernel.org/linux-samsung-soc/20230127211527.260060-1-krzysztof.kozlowski@linaro.org/T/#t
---
.../devicetree/bindings/usb/samsung,exynos-dwc3.yaml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
index 6b9a3bcb3926..42ceaf13cd5d 100644
--- a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
@@ -108,19 +108,19 @@ examples:
#include <dt-bindings/clock/exynos5420.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
- usb {
+ usb@12000000 {
compatible = "samsung,exynos5250-dwusb3";
#address-cells = <1>;
#size-cells = <1>;
- ranges;
+ ranges = <0x0 0x12000000 0x10000>;
clocks = <&clock CLK_USBD300>;
clock-names = "usbdrd30";
vdd33-supply = <&ldo9_reg>;
vdd10-supply = <&ldo11_reg>;
- usb@12000000 {
+ usb@0 {
compatible = "snps,dwc3";
- reg = <0x12000000 0x10000>;
+ reg = <0x0 0x10000>;
interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
phys = <&usbdrd_phy0 0>, <&usbdrd_phy0 1>;
phy-names = "usb2-phy", "usb3-phy";
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] dt-bindings: usb: samsung,exynos-dwc3: allow unit address in DTS
2023-01-27 21:17 [PATCH v2] dt-bindings: usb: samsung,exynos-dwc3: allow unit address in DTS Krzysztof Kozlowski
@ 2023-01-30 21:22 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2023-01-30 21:22 UTC (permalink / raw
To: Krzysztof Kozlowski
Cc: Greg Kroah-Hartman, Rob Herring, Martin Jücker,
Marek Szyprowski, Sam Protsenko, linux-arm-kernel,
Krzysztof Kozlowski, devicetree, linux-samsung-soc, phone-devel,
Henrik Grimler, Chanwoo Choi, linux-usb, Alim Akhtar,
~postmarketos/upstreaming, Chanho Park
On Fri, 27 Jan 2023 22:17:48 +0100, Krzysztof Kozlowski wrote:
> The Samsung Exynos SoC USB 3.0 DWC3 Controller is a simple wrapper of
> actual DWC3 Controller device node. It handles necessary Samsung
> Exynos-specific resources (regulators, clocks), but does not have its
> own MMIO address space.
>
> However neither simple-bus bindings nor dtc W=1 accept device nodes in
> soc@ node which do not have unit address.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Changes since v1:
> 1. Use ranges with values and drop reg from usb-wrapper node.
> 2. Keep "usb" as wrapper's node name.
>
> DTS fixes are here:
> https://lore.kernel.org/linux-samsung-soc/20230127211527.260060-1-krzysztof.kozlowski@linaro.org/T/#t
> ---
> .../devicetree/bindings/usb/samsung,exynos-dwc3.yaml | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-30 21:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-27 21:17 [PATCH v2] dt-bindings: usb: samsung,exynos-dwc3: allow unit address in DTS Krzysztof Kozlowski
2023-01-30 21:22 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).