From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: usb: uhci: convert to dt schema
Date: Mon, 22 Apr 2024 13:49:17 +0200 [thread overview]
Message-ID: <0b6bf7b9-f9c6-40c4-a166-7bdd4984b023@kernel.org> (raw)
In-Reply-To: <20240422093706.324115-1-sheharyaar48@gmail.com>
On 22/04/2024 11:37, Mohammad Shehar Yaar Tausif wrote:
> Convert USB UHCI bindings to DT schema.
Please mention changes from pure conversion, so documenting aspeed
compatibles and missing properties.
>
> Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
> ---
...
...
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +if:
This should be under allOf
> + properties:
> + compatible:
> + contains:
> + const: generic-uhci
> +then:
> + allOf:
> + - $ref: usb-hcd.yaml
This is confusing. Aspeed is not different here.
> + if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - aspeed,ast2400-uhci
> + - aspeed,ast2500-uhci
> + - aspeed,ast2600-uhci
> + then:
> + properties:
> + '#ports':
> + $ref: /schemas/types.yaml#/definitions/uint32
And the #ports property looks valid for generic-ahci. Why do you think
it is not valid?
> + clocks:
> + maxItems: 1
Define properties top-level.
> + required:
> + - clocks
This looks required for generic-uhci as well. Why did you put it only
for aspeed?
Best regards,
Krzysztof
prev parent reply other threads:[~2024-04-22 11:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 9:37 [PATCH v2] dt-bindings: usb: uhci: convert to dt schema Mohammad Shehar Yaar Tausif
2024-04-22 11:49 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b6bf7b9-f9c6-40c4-a166-7bdd4984b023@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sheharyaar48@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).