From: Jens Axboe <axboe@kernel.dk>
To: Zorro Lang <zlang@redhat.com>
Cc: Amir Goldstein <amir73il@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-unionfs@vger.kernel.org
Subject: Re: [PATCH] ovl: disable IOCB_DIO_CALLER_COMP
Date: Tue, 26 Sep 2023 09:31:53 -0600 [thread overview]
Message-ID: <ef88fe8e-633d-4335-9cfd-2055857727db@kernel.dk> (raw)
In-Reply-To: <20230926152328.5vpz7yddmsjahkxt@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
On 9/26/23 9:23 AM, Zorro Lang wrote:
> On Mon, Sep 25, 2023 at 12:21:35AM -0600, Jens Axboe wrote:
>> overlayfs copies the kiocb flags when it sets up a new kiocb to handle
>> a write, but it doesn't properly support dealing with the deferred
>> caller completions of the kiocb. This means it doesn't get the final
>> write completion value, and hence will complete the write with '0' as
>> the result.
>>
>> We could support the caller completions in overlayfs, but for now let's
>> just disable them in the generated write kiocb.
>>
>> Reported-by: Zorro Lang <zlang@redhat.com>
>> Link: https://lore.kernel.org/io-uring/20230924142754.ejwsjen5pvyc32l4@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com/
>> Fixes: 8c052fb3002e ("iomap: support IOCB_DIO_CALLER_COMP")
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>>
>> ---
>
> Thanks Jens, the fstests generic/617 works on latest linux kernel with
> this patch now.
Excellent, thanks for re-testing.
--
Jens Axboe
prev parent reply other threads:[~2023-09-26 15:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 6:21 [PATCH] ovl: disable IOCB_DIO_CALLER_COMP Jens Axboe
2023-09-25 9:18 ` Amir Goldstein
2023-09-25 9:35 ` Jens Axboe
2023-09-25 9:39 ` Christian Brauner
2023-09-25 9:51 ` Jens Axboe
2023-09-25 9:38 ` Christian Brauner
2023-09-26 15:23 ` Zorro Lang
2023-09-26 15:31 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef88fe8e-633d-4335-9cfd-2055857727db@kernel.dk \
--to=axboe@kernel.dk \
--cc=amir73il@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).