From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Christian Brauner <brauner@kernel.org>, linux-unionfs@vger.kernel.org
Subject: Re: [PATCH 0/4] ovl: new mount options lowerdir+,datadir+
Date: Mon, 30 Oct 2023 20:45:47 +0200 [thread overview]
Message-ID: <CAOQ4uxjD6_G_u7jP88D-mpYAEjYDLEUQcZ=HTR1ub0ts5+dFRw@mail.gmail.com> (raw)
In-Reply-To: <CAJfpegvMtqk6eiLvGbC+2oQDHSP6M2HEZVWzTFpVpbWN6GCaOQ@mail.gmail.com>
On Mon, Oct 30, 2023 at 5:41 PM Miklos Szeredi <miklos@szeredi.hu> wrote:
>
> On Mon, 30 Oct 2023 at 13:04, Amir Goldstein <amir73il@gmail.com> wrote:
> >
> > Miklos,
> >
> > As discussed, here are the patches for the new mount options.
> >
> > - Only string format is supported
> > - Legacy lowerdir= cannot be mixed with new lowerdir+,datadir+
> > - lowerdir+,datadir+ are not escaped
> > - lowerdir,upperdir,workdir are escaped as always
> >
> > I did not find a good reason to change escaping of upperdir,workdir.
> > We can skip escaping when we add support for path format.
>
> Looks good, other than the minor error reporting issue.
>
Pushed fix to overlayfs-next and added some documentation.
Thanks,
Amir.
prev parent reply other threads:[~2023-10-30 18:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 12:04 [PATCH 0/4] ovl: new mount options lowerdir+,datadir+ Amir Goldstein
2023-10-30 12:04 ` [PATCH 1/4] ovl: remove unused code in lowerdir param parsing Amir Goldstein
2023-10-30 12:04 ` [PATCH 2/4] ovl: store and show the user provided lowerdir mount option Amir Goldstein
2023-10-30 12:04 ` [PATCH 3/4] ovl: refactor layer parsing helpers Amir Goldstein
2023-10-30 15:36 ` Miklos Szeredi
2023-10-30 17:41 ` Amir Goldstein
2023-10-30 12:04 ` [PATCH 4/4] ovl: add support for appending lowerdirs one by one Amir Goldstein
2023-10-30 13:06 ` Amir Goldstein
2023-10-30 15:41 ` [PATCH 0/4] ovl: new mount options lowerdir+,datadir+ Miklos Szeredi
2023-10-30 18:45 ` Amir Goldstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOQ4uxjD6_G_u7jP88D-mpYAEjYDLEUQcZ=HTR1ub0ts5+dFRw@mail.gmail.com' \
--to=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).