From: Amir Goldstein <amir73il@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>, Sasha Levin <sashal@kernel.org>
Cc: Jingbo Xu <jefflexu@linux.alibaba.com>,
stable@vger.kernel.org, linux-unionfs@vger.kernel.org
Subject: Re: [STABLE 6.6.y] ovl: fix memory leak in ovl_parse_param()
Date: Tue, 30 Apr 2024 17:11:51 +0300 [thread overview]
Message-ID: <CAOQ4uxgP6gDTZWjsVvDF8kFqCihSccmyXfzkxTgNs--rrdaOfg@mail.gmail.com> (raw)
In-Reply-To: <2024043049-divisibly-discover-7a32@gregkh>
On Tue, Apr 30, 2024 at 10:53 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Apr 30, 2024 at 11:48:54AM +0800, Jingbo Xu wrote:
> > From: Amir Goldstein <amir73il@gmail.com>
> >
> > commit 37f32f52643869131ec01bb69bdf9f404f6109fb upstream.
> >
> > On failure to parse parameters in ovl_parse_param_lowerdir(), it is
> > necessary to update ctx->nr with the correct nr before using
> > ovl_reset_lowerdirs() to release l->name.
> >
> > Reported-and-tested-by: syzbot+26eedf3631650972f17c@syzkaller.appspotmail.com
> > Fixes: c835110b588a ("ovl: remove unused code in lowerdir param parsing")
> > Co-authored-by: Edward Adam Davis <eadavis@qq.com>
> > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> > Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
> > ---
> > Commit c835110b588a ("ovl: remove unused code in lowerdir param
> > parsing") was back ported to 6.6.y as a "Stable-dep-of" of commit
> > 2824083db76c ("ovl: Always reject mounting over case-insensitive
> > directories"), while omitting the fix for commit c835110b588a itself.
> > Maybe that is because by the time commit 37f32f526438 (the fix) is merged
> > into master branch, commit c835110b588a has not been back ported to 6.6.y
> > yet.
This is strange.
The 6.6 backports were posted by Sasha on Mar 2024.
The omitted fix was merged in Nov 2023.
Sasha,
Do you understand what went wrong?
Thanks,
Amir.
prev parent reply other threads:[~2024-04-30 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 3:48 [STABLE 6.6.y] ovl: fix memory leak in ovl_parse_param() Jingbo Xu
2024-04-30 7:52 ` Greg KH
2024-04-30 14:11 ` Amir Goldstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ4uxgP6gDTZWjsVvDF8kFqCihSccmyXfzkxTgNs--rrdaOfg@mail.gmail.com \
--to=amir73il@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).