From: Miklos Szeredi <miklos@szeredi.hu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, linux-unionfs@vger.kernel.org
Subject: Re: [PATCH 0/2] overlayfs lock ordering changes
Date: Mon, 14 Aug 2023 14:56:51 +0200 [thread overview]
Message-ID: <CAJfpegv6w2zd-X1FJihdA5VtKd=toh9Mxfiu=Nz0kigQ5YBLbQ@mail.gmail.com> (raw)
In-Reply-To: <CAOQ4uxhUQ8wCb3T3P_P5Ere1Hd+EaZ7ub2V_ErYU0rdrr=QRbw@mail.gmail.com>
On Mon, 14 Aug 2023 at 13:38, Amir Goldstein <amir73il@gmail.com> wrote:
> Well, I didn't do it to silence lockdep. I did it as a prereq for
> start-write-safe fsnotify hooks (see [1] above).
> Silencing lockdep is an added bonus that I observed along the way.
>
> v2 [2] has a less hacky, but more noisy version of this patch which
> minimizes the scope of ovl_want_write() to when we need it.
> Let me know if this is what you had in mind.
Yes, I like this better, thanks.
Please post this as a series, and I'll do a review. I've already
caught a glance of an error case bug in one of the patches.
Thanks,
Miklos
prev parent reply other threads:[~2023-08-14 12:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 15:37 [PATCH 0/2] overlayfs lock ordering changes Amir Goldstein
2023-07-20 15:37 ` [PATCH 1/2] ovl: reorder ovl_want_write() after ovl_inode_lock() Amir Goldstein
2023-07-20 15:37 ` [PATCH 2/2] ovl: avoid lockdep warning with open and llseek of lower file Amir Goldstein
2023-08-10 18:23 ` [PATCH 0/2] overlayfs lock ordering changes Amir Goldstein
2023-08-11 13:06 ` Miklos Szeredi
2023-08-14 11:37 ` Amir Goldstein
2023-08-14 12:56 ` Miklos Szeredi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfpegv6w2zd-X1FJihdA5VtKd=toh9Mxfiu=Nz0kigQ5YBLbQ@mail.gmail.com' \
--to=miklos@szeredi.hu \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-unionfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).