From: Mimi Zohar <zohar@linux.ibm.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: hdanton@sina.com, linux-fsdevel@vger.kernel.org,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-unionfs@vger.kernel.org,
miklos@szeredi.hu, mszeredi@redhat.com,
syzbot@syzkalhler.appspotmail.com,
syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk
Subject: Re: [syzbot] [integrity] [overlayfs] possible deadlock in mnt_want_write (2)
Date: Thu, 05 Oct 2023 09:35:40 -0400 [thread overview]
Message-ID: <97be76d94fdacf369a324b6122d5f5bc19a3838c.camel@linux.ibm.com> (raw)
In-Reply-To: <CAOQ4uxgfJ4owqzh99t65MyT5A99BbwkLQ-sHumCUWyqSw-Rd5g@mail.gmail.com>
On Thu, 2023-10-05 at 16:22 +0300, Amir Goldstein wrote:
> On Thu, Oct 5, 2023 at 4:14 PM Mimi Zohar <zohar@linux.ibm.com> wrote:
> >
> > On Thu, 2023-10-05 at 13:26 +0300, Amir Goldstein wrote:
> > > On Thu, Oct 5, 2023 at 12:59 PM syzbot
> > > <syzbot+b42fe626038981fb7bfa@syzkaller.appspotmail.com> wrote:
> > > >
> > > > Hello,
> > > >
> > > > syzbot tried to test the proposed patch but the build/boot failed:
> > >
> > > My mistake. Please try again:
> > >
> > > #syz test: https://github.com/amir73il/linux ima-ovl-fix
> >
> > Thanks, Amir. "mutext_init(&iint->mutex); moved, but the status
> > initialization lines 161-166 were dropped. They're needed by IMA-
> > appraisal for signature verification.
> >
> > iint->ima_file_status = INTEGRITY_UNKNOWN;
> > iint->ima_mmap_status = INTEGRITY_UNKNOWN;
> > iint->ima_bprm_status = INTEGRITY_UNKNOWN;
> > iint->ima_read_status = INTEGRITY_UNKNOWN;
> > iint->ima_creds_status = INTEGRITY_UNKNOWN;
> > iint->evm_status = INTEGRITY_UNKNOWN;
> >
>
> They are dropped from iint_init_once()
> They are not needed there because there are now set
> in every iint allocation in iint_init_always()
> instead of being set in iint_free()
I was only looking at the patch and noticed the removal. Thanks, this
looks good.
Mimi
prev parent reply other threads:[~2023-10-05 14:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <00000000000067d24205c4d0e599@google.com>
2023-06-06 9:12 ` [syzbot] possible deadlock in mnt_want_write (2) Miklos Szeredi
2023-06-06 9:12 ` syzbot
2023-06-06 9:13 ` Miklos Szeredi
2023-10-04 16:45 ` [syzbot] [integrity] [overlayfs] " syzbot
2023-10-05 9:36 ` Amir Goldstein
2023-10-05 9:59 ` syzbot
2023-10-05 10:26 ` Amir Goldstein
2023-10-05 10:46 ` syzbot
2023-10-05 11:47 ` Mimi Zohar
2023-10-05 13:22 ` Amir Goldstein
2023-10-05 13:35 ` Mimi Zohar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97be76d94fdacf369a324b6122d5f5bc19a3838c.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=amir73il@gmail.com \
--cc=hdanton@sina.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mszeredi@redhat.com \
--cc=syzbot@syzkalhler.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).