From: "Weiß, Simone" <Simone.Weiss@elektrobit.com>
To: "miklos@szeredi.hu" <miklos@szeredi.hu>,
"amir73il@gmail.com" <amir73il@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>
Subject: Re: possible deadlock in ovl_llseek 27c1936af506
Date: Wed, 13 Mar 2024 15:50:10 +0000 [thread overview]
Message-ID: <73196bf24b7d8f14c2b47dbd6c248905e0ac994d.camel@elektrobit.com> (raw)
In-Reply-To: <CAJfpeguBfKB4MGEUkJ=+ZFT9uYJ1DXtCTW9oLrEE0af7XTi=VA@mail.gmail.com>
On Wed, 2024-03-13 at 15:47 +0100, Miklos Szeredi wrote:
> On Wed, 13 Mar 2024 at 14:14, Amir Goldstein <amir73il@gmail.com> wrote:
>
> > The reason for this report is calling llseek() on lower ovl from
> > ovl_copy_up_data() when ovl_copy_up_data() is called with upper
> > inode lock and the lower ovl uses the same upper fs.
> >
> > It looks to me like the possible deadlock should have been solved by commit
> > c63e56a4a652 ovl: do not open/llseek lower file with upper sb_writers held
> > that moved ovl_copy_up_data() out of the inode_lock() scope.
>
> That commit is in v6.7, so something different must be happening on v6.8-rc1.
>
> Simone, please send a new report for v6.8-rc1 if a lockdep splat can
> be reproduced on that kernel.
>
> Thanks,
> Miklos
Sure, I will try to reproduce it again and send a new report if needed.
Thanks,
Simone
prev parent reply other threads:[~2024-03-13 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 7:10 possible deadlock in ovl_llseek 27c1936af506 Weiß, Simone
2024-03-12 10:54 ` Hillf Danton
2024-03-13 13:14 ` Amir Goldstein
2024-03-13 14:47 ` Miklos Szeredi
2024-03-13 15:50 ` Weiß, Simone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73196bf24b7d8f14c2b47dbd6c248905e0ac994d.camel@elektrobit.com \
--to=simone.weiss@elektrobit.com \
--cc=amir73il@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).