From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Amir Goldstein <amir73il@gmail.com>, Jan Kara <jack@suse.cz>,
Christian Brauner <brauner@kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>,
linux-unionfs@vger.kernel.org, ltp@lists.linux.it
Subject: Re: [PATCH 1/3] fanotify13: Test watching overlayfs upper fs
Date: Fri, 15 Sep 2023 11:02:08 +0200 [thread overview]
Message-ID: <20230915090208.GA30488@pevik> (raw)
In-Reply-To: <ZQQVm5p08PmHRX1A@yuki>
Hi all,
...
> > - } else {
> > + } else if (skip) {
> > tst_brk_(file, lineno, TBROK | TERRNO,
> > "overlayfs mount failed");
> > }
> The skip flag should be called strict, at least that is what we usually
> name it, but that is very minor.
> ...
> > static struct tst_test test = {
> > .test = do_test,
> > .tcnt = ARRAY_SIZE(test_cases),
> > + .test_variants = 2,
> > .setup = do_setup,
> > .cleanup = do_cleanup,
> > .needs_root = 1,
> > .mount_device = 1,
> > - .mntpoint = MOUNT_PATH,
> > + .mntpoint = OVL_BASE_MNTPOINT,
> > .all_filesystems = 1,
> > .tags = (const struct tst_tag[]) {
> > {"linux-git", "c285a2f01d69"},
> The git hash for the regression test with variant=1 should have been
> added here.
> The rest looks good to me. With the two minor issues fixed:
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
> @Peter Vorel Feel free to push the patch with the two fixes applied.
Thanks for spotting both issues, fixed and merged.
Kind regards,
Petr
next prev parent reply other threads:[~2023-09-15 9:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-03 11:15 [PATCH 0/3] Tests for fanotify and overlayfs Amir Goldstein
2023-09-03 11:15 ` [PATCH 1/3] fanotify13: Test watching overlayfs upper fs Amir Goldstein
2023-09-14 10:32 ` [LTP] " Richard Palethorpe
2023-09-14 13:24 ` Amir Goldstein
2023-09-15 6:51 ` Petr Vorel
2023-09-15 8:28 ` Cyril Hrubis
2023-09-15 9:02 ` Petr Vorel [this message]
2023-09-03 11:15 ` [PATCH 2/3] fanotify13: Test watching overlayfs with FAN_REPORT_FID Amir Goldstein
2023-09-03 11:15 ` [PATCH 3/3] fanotify13: Test unique overlayfs fsid Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230915090208.GA30488@pevik \
--to=pvorel@suse.cz \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=chrubis@suse.cz \
--cc=jack@suse.cz \
--cc=linux-unionfs@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).