From: Johannes Berg <johannes@sipsolutions.net>
To: Yueh-Shun Li <shamrocklee@posteo.net>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: linux-um@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] um: Makefile: use bash from the environment
Date: Thu, 28 Mar 2024 10:13:54 +0100 [thread overview]
Message-ID: <c4121cbbf6673a8c97db1460a8d6847ccc49d4f3.camel@sipsolutions.net> (raw)
In-Reply-To: <20240323174450.18376-1-shamrocklee@posteo.net>
On Sat, 2024-03-23 at 17:44 +0000, Yueh-Shun Li wrote:
> Set Makefile SHELL to bash instead of /bin/bash for better portability.
>
> Some systems do not install binaries to /bin, and therefore do not
> provide /bin/bash. This includes Linux distros which intentionally avoid
> implementing the Filesystem Hierarchy Standard (FHS), such as NixOS and
> Guix System.
>
> The recipies inside arch/um/Makefile don't require top-level Bash to
> build, and setting "SHELL" to "bash" makes Make pick the Bash executable
> from the environment, hence this patch.
>
> Changes since last roll:
> - Rebase onto a more recent commit on the master branch.
> - Remove a dangling in-text citation from the change log.
> - Reword the change log.
Not sure I'd have added the change log here (in this case at least), but
anyway:
Reviewed-by: Johannes Berg <johannes@sipsolutions.net
johannes
prev parent reply other threads:[~2024-03-28 9:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 17:44 [PATCH v2] um: Makefile: use bash from the environment Yueh-Shun Li
2024-03-28 9:13 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4121cbbf6673a8c97db1460a8d6847ccc49d4f3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=anton.ivanov@cambridgegreys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
--cc=shamrocklee@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).