From: Johannes Berg <johannes@sipsolutions.net>
To: Duoming Zhou <duoming@zju.edu.cn>, linux-kernel@vger.kernel.org
Cc: linux-um@lists.infradead.org, richard@nod.at,
anton.ivanov@cambridgegreys.com, axboe@kernel.dk,
brauner@kernel.org, hare@suse.de, jinpu.wang@ionos.com
Subject: Re: [PATCH] um: Fix return value in ubd_init()
Date: Thu, 28 Mar 2024 09:27:12 +0100 [thread overview]
Message-ID: <6fa3c18b3421d5dfc80c82ce29a49171c1841bf0.camel@sipsolutions.net> (raw)
In-Reply-To: <20240306091259.18605-1-duoming@zju.edu.cn>
On Wed, 2024-03-06 at 17:12 +0800, Duoming Zhou wrote:
> When kmalloc_array() fails to allocate memory, the ubd_init()
> should return -ENOMEM instead of -1. So, fix it.
Not sure this really matters, but the code seems cleaner with it :)
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
johannes
prev parent reply other threads:[~2024-03-28 8:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 9:12 [PATCH] um: Fix return value in ubd_init() Duoming Zhou
2024-03-28 8:27 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fa3c18b3421d5dfc80c82ce29a49171c1841bf0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=anton.ivanov@cambridgegreys.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=duoming@zju.edu.cn \
--cc=hare@suse.de \
--cc=jinpu.wang@ionos.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).