From: Richard Weinberger <richard@nod.at>
To: Roberto Sassu <roberto.sassu@huaweicloud.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
anton ivanov <anton.ivanov@cambridgegreys.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-um <linux-um@lists.infradead.org>,
Roberto Sassu <roberto.sassu@huawei.com>
Subject: Re: [PATCH] um: Add winch to winch_handlers before registering winch IRQ
Date: Tue, 23 Apr 2024 10:11:03 +0200 (CEST) [thread overview]
Message-ID: <539232323.17201.1713859863502.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <15d5da65079d072856ef5e8d88040df2095bb6b7.camel@huaweicloud.com>
----- Ursprüngliche Mail -----
> Von: "Roberto Sassu" <roberto.sassu@huaweicloud.com>
> An: "Johannes Berg" <johannes@sipsolutions.net>, "richard" <richard@nod.at>, "anton ivanov"
> <anton.ivanov@cambridgegreys.com>
> CC: "linux-kernel" <linux-kernel@vger.kernel.org>, "linux-um" <linux-um@lists.infradead.org>, "Roberto Sassu"
> <roberto.sassu@huawei.com>
> Gesendet: Dienstag, 23. April 2024 09:22:31
> Betreff: Re: [PATCH] um: Add winch to winch_handlers before registering winch IRQ
> On Thu, 2024-03-28 at 09:25 +0100, Johannes Berg wrote:
>> On Thu, 2024-03-07 at 11:49 +0100, Roberto Sassu wrote:
>> > From: Roberto Sassu <roberto.sassu@huawei.com>
>> >
>> > Registering a winch IRQ is racy, an interrupt may occur before the winch is
>> > added to the winch_handlers list.
>> >
>> > If that happens, register_winch_irq() adds to that list a winch that is
>> > scheduled to be (or has already been) freed, causing a panic later in
>> > winch_cleanup().
>> >
>> > Avoid the race by adding the winch to the winch_handlers list before
>> > registering the IRQ, and rolling back if um_request_irq() fails.
>> >
>>
>> Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
>
> Thank you! Richard, are you going to pick this up?
Yes, it's already in my local queue.
Thanks,
//richard
prev parent reply other threads:[~2024-04-23 8:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 10:49 [PATCH] um: Add winch to winch_handlers before registering winch IRQ Roberto Sassu
2024-03-07 12:43 ` Roberto Sassu
2024-03-28 8:11 ` Roberto Sassu
2024-03-28 8:25 ` Johannes Berg
2024-04-23 7:22 ` Roberto Sassu
2024-04-23 8:11 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539232323.17201.1713859863502.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=anton.ivanov@cambridgegreys.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=roberto.sassu@huawei.com \
--cc=roberto.sassu@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).