From: "Paul E. McKenney" <paulmck@kernel.org>
To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Cc: Zhenhua Huang <quic_zhenhuah@quicinc.com>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: [PATCH fs/proc/bootconfig] remove redundant comments from /proc/bootconfig
Date: Wed, 3 Apr 2024 12:16:28 -0700 [thread overview]
Message-ID: <f036c5b0-20cc-40c1-85f9-69fa9edd0c95@paulmck-laptop> (raw)
commit 717c7c894d4b ("fs/proc: Add boot loader arguments as comment to
/proc/bootconfig") adds bootloader argument comments into /proc/bootconfig.
/proc/bootconfig shows boot_command_line[] multiple times following
every xbc key value pair, that's duplicated and not necessary.
Remove redundant ones.
Output before and after the fix is like:
key1 = value1
*bootloader argument comments*
key2 = value2
*bootloader argument comments*
key3 = value3
*bootloader argument comments*
...
key1 = value1
key2 = value2
key3 = value3
*bootloader argument comments*
...
Fixes: 717c7c894d4b ("fs/proc: Add boot loader arguments as comment to /proc/bootconfig")
Signed-off-by: Zhenhua Huang <quic_zhenhuah@quicinc.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: <linux-trace-kernel@vger.kernel.org>
Cc: <linux-fsdevel@vger.kernel.org>
diff --git a/fs/proc/bootconfig.c b/fs/proc/bootconfig.c
index 902b326e1e560..e5635a6b127b0 100644
--- a/fs/proc/bootconfig.c
+++ b/fs/proc/bootconfig.c
@@ -62,12 +62,12 @@ static int __init copy_xbc_key_value_list(char *dst, size_t size)
break;
dst += ret;
}
- if (ret >= 0 && boot_command_line[0]) {
- ret = snprintf(dst, rest(dst, end), "# Parameters from bootloader:\n# %s\n",
- boot_command_line);
- if (ret > 0)
- dst += ret;
- }
+ }
+ if (ret >= 0 && boot_command_line[0]) {
+ ret = snprintf(dst, rest(dst, end), "# Parameters from bootloader:\n# %s\n",
+ boot_command_line);
+ if (ret > 0)
+ dst += ret;
}
out:
kfree(key);
next reply other threads:[~2024-04-03 19:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 19:16 Paul E. McKenney [this message]
2024-04-03 23:55 ` [PATCH fs/proc/bootconfig] remove redundant comments from /proc/bootconfig Masami Hiramatsu
2024-04-04 17:43 ` Paul E. McKenney
2024-04-05 1:23 ` Masami Hiramatsu
2024-04-05 2:57 ` Masami Hiramatsu
2024-04-05 4:25 ` Paul E. McKenney
2024-04-06 2:11 ` Masami Hiramatsu
2024-04-08 19:18 ` Paul E. McKenney
2024-04-09 0:25 ` Masami Hiramatsu
2024-04-09 0:53 ` Paul E. McKenney
2024-04-09 4:42 ` [PATCH v2 fs/proc/bootconfig 0/2] " Paul E. McKenney
2024-04-09 4:43 ` [PATCH v2 fs/proc/bootconfig 1/2] fs/proc: " Paul E. McKenney
2024-04-09 4:43 ` [PATCH v2 fs/proc/bootconfig 2/2] fs/proc: Skip bootloader comment if no embedded kernel parameters Paul E. McKenney
2024-04-09 14:32 ` [PATCH v2 fs/proc/bootconfig 0/2] remove redundant comments from /proc/bootconfig Masami Hiramatsu
2024-04-09 16:07 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f036c5b0-20cc-40c1-85f9-69fa9edd0c95@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=quic_zhenhuah@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).