From: Ingo Molnar <mingo@kernel.org>
To: "Naik, Avadhut" <avadnaik@amd.com>
Cc: Avadhut Naik <avadhut.naik@amd.com>,
linux-trace-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
rostedt@goodmis.org, tony.luck@intel.com, bp@alien8.de,
x86@kernel.org, sohil.mehta@intel.com, yazen.ghannam@amd.com
Subject: Re: [PATCH] x86/mce: Clean up TP_printk() output line of the mce_record tracepoint
Date: Sat, 30 Mar 2024 11:38:55 +0100 [thread overview]
Message-ID: <Zgfrv0NcNym681aZ@gmail.com> (raw)
In-Reply-To: <93895d82-ae81-4fa3-8d58-9958d7130dcd@amd.com>
* Naik, Avadhut <avadnaik@amd.com> wrote:
> On 3/29/2024 02:11, Ingo Molnar wrote:
> >
> > Please split out the other (capitalization) changes to the output into
> > a separate patch.
> >
> Okay. Will put the capitalization changes into a separate patch.
>
> > - While at it, don't forget to:
> >
> > s/ADDR/MISC/SYND
> > /addr/misc/synd
> >
> These are actually acronyms for Address, Miscellaneous and Syndrome registers.
I kept SYND capitalized in the patch:
> > + TP_printk("CPU: %d, MCGc/s: %llx/%llx, MC%d: %016Lx, IPID: %016Lx, addr: %016Lx, misc: %016Lx, SYND: %016Lx, RIP: %02x:<%016Lx>, TSC: %llx, vendor: %u, CPUID: %x, time: %llu, socket: %u, APIC: %x",
But I guess ADDR and MISC are fine too.
To move forward with this I've committed the cleanup in tip:x86/cpu:
ac5e80e94f5c x86/mce: Clean up TP_printk() output line of the 'mce_record' tracepoint
... and please post extensions of the tracepoint on top of that sane(er) code.
Thanks,
Ingo
next prev parent reply other threads:[~2024-03-30 10:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 18:04 [PATCH v5 0/2] Update mce_record tracepoint Avadhut Naik
2024-03-28 18:04 ` [PATCH v5 1/2] tracing: Include PPIN in " Avadhut Naik
2024-03-29 7:11 ` [PATCH] x86/mce: Clean up TP_printk() output line of the " Ingo Molnar
2024-03-29 16:22 ` Naik, Avadhut
2024-03-29 16:50 ` Luck, Tony
2024-03-29 18:23 ` Naik, Avadhut
2024-03-30 10:38 ` Ingo Molnar [this message]
2024-03-28 18:04 ` [PATCH v5 2/2] tracing: Include Microcode Revision in " Avadhut Naik
2024-03-28 18:14 ` [PATCH v5 0/2] Update " Sohil Mehta
2024-03-29 0:13 ` Naik, Avadhut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zgfrv0NcNym681aZ@gmail.com \
--to=mingo@kernel.org \
--cc=avadhut.naik@amd.com \
--cc=avadnaik@amd.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sohil.mehta@intel.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).