From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Mark Brown <broonie@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Shuah Khan <shuah@kernel.org>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
Mark Rutland <mark.rutland@arm.com>,
Aishwarya TCV <aishwarya.tcv@arm.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 2/2] tracing/selftests: Default to verbose mode when running in kselftest
Date: Sun, 7 Apr 2024 02:05:10 +0500 [thread overview]
Message-ID: <470d67f2-dd6f-48e1-8f42-a6c72e2d98e7@collabora.com> (raw)
In-Reply-To: <20240325-kselftest-ftrace-ktap-verbose-v1-2-3785199809da@kernel.org>
On 3/25/24 9:15 PM, Mark Brown wrote:
> In order to facilitate debugging of issues from automated runs of the ftrace
> selftests turn on verbose logging by default when run from the kselftest
> runner. This is primarily used by automated systems where developers may
> not have direct access to the system so defaulting to providing diagnostic
> information which might help debug problems seems like a good idea.
>
> When tests pass no extra output is generated, when they fail a full log of
> the test run is provided. Since this really is rather verbose when there are
> a large number of test failures or output is slow (eg, with a serial
> console) this could substantially increase the run time for the tests which
> might present problems with timeout detection for affected systems,
> hopefully we keep the tests running well enough that this is not too much
> of an issue.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> tools/testing/selftests/ftrace/ftracetest-ktap | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ftrace/ftracetest-ktap b/tools/testing/selftests/ftrace/ftracetest-ktap
> index b3284679ef3a..14e62ef3f3b9 100755
> --- a/tools/testing/selftests/ftrace/ftracetest-ktap
> +++ b/tools/testing/selftests/ftrace/ftracetest-ktap
> @@ -5,4 +5,4 @@
> #
> # Copyright (C) Arm Ltd., 2023
>
> -./ftracetest -K
> +./ftracetest -K -v
>
--
BR,
Muhammad Usama Anjum
next prev parent reply other threads:[~2024-04-06 21:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 16:15 [PATCH 0/2] tracing/selftests: Verbosity improvements to KTAP output Mark Brown
2024-03-25 16:15 ` [PATCH 1/2] tracing/selftests: Support log output when generating " Mark Brown
2024-04-06 21:03 ` Muhammad Usama Anjum
2024-03-25 16:15 ` [PATCH 2/2] tracing/selftests: Default to verbose mode when running in kselftest Mark Brown
2024-04-06 21:05 ` Muhammad Usama Anjum [this message]
2024-03-26 16:08 ` [PATCH 0/2] tracing/selftests: Verbosity improvements to KTAP output Steven Rostedt
2024-03-26 19:11 ` Shuah Khan
2024-04-04 16:32 ` Shuah Khan
2024-04-06 12:36 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470d67f2-dd6f-48e1-8f42-a6c72e2d98e7@collabora.com \
--to=usama.anjum@collabora.com \
--cc=aishwarya.tcv@arm.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).