From: Steven Rostedt <rostedt@goodmis.org>
To: Mike Rapoport <rppt@kernel.org>
Cc: "Guilherme G. Piccoli" <gpiccoli@igalia.com>,
"Luck, Tony" <tony.luck@intel.com>,
Kees Cook <keescook@chromium.org>,
Joel Fernandes <joel@joelfernandes.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-trace-kernel@vger.kernel.org"
<linux-trace-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Lorenzo Stoakes <lstoakes@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
"linux-hardening@vger.kernel.org"
<linux-hardening@vger.kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Ross Zwisler <zwisler@google.com>,
"wklin@google.com" <wklin@google.com>,
Vineeth Remanan Pillai <vineeth@bitbyteword.org>,
Suleiman Souhlal <suleiman@google.com>,
Linus Torvalds <torvalds@linuxfoundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Subject: Re: [POC][RFC][PATCH 0/2] pstore/mm/x86: Add wildcard memmap to map pstore consistently
Date: Thu, 9 May 2024 16:33:10 -0400 [thread overview]
Message-ID: <20240509163310.2aa0b2e1@rorschach.local.home> (raw)
In-Reply-To: <Zj0w9MFfjFm6XqT5@kernel.org>
On Thu, 9 May 2024 23:24:20 +0300
Mike Rapoport <rppt@kernel.org> wrote:
> On Thu, May 09, 2024 at 01:31:22PM -0400, Steven Rostedt wrote:
> > On Thu, 9 May 2024 00:00:23 -0400
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > > I tried this approach and it unfortunately picks a different physical
> > > location every time :-(
> > >
> > > So it is either adding to e820 tables or we create a new way to
> > > allocate memory at early boot up.
> > >
> >
> > Hmm, now I'm testing it more and it always seems to end up in the same
> > location. I'm not sure why it failed the first three times I tried it :-/
>
> If the kernel and the command line were the same, they shouldn't have.
> e820 translates to memblock the same way every boot and the early
> allocations also do not change from boot to boot.
>
> Could it be that three runs that failed had some differences in the kernel
> parameters?
>
I wonder if KASLR caused it or not. But when I first added it to
another machine, it failed to get the same address on the second boot,
but was fine after that.
Could be just something with my setup. I'm going to backport this to
5.15 and test this on a Chromebook and see what happens there (as
that's the motivation behind this work).
-- Steve
prev parent reply other threads:[~2024-05-09 20:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 21:02 [POC][RFC][PATCH 0/2] pstore/mm/x86: Add wildcard memmap to map pstore consistently Steven Rostedt
2024-04-09 21:02 ` [POC][RFC][PATCH 1/2] mm/x86: Add wildcard * option as memmap=nn*align:name Steven Rostedt
2024-04-09 22:23 ` Kees Cook
2024-04-09 23:11 ` Steven Rostedt
2024-04-09 23:41 ` Kees Cook
2024-04-12 20:59 ` Mike Rapoport
2024-04-12 22:19 ` Steven Rostedt
2024-04-15 17:22 ` Kees Cook
2024-05-01 14:57 ` Mike Rapoport
2024-05-06 10:38 ` Ard Biesheuvel
2024-05-08 23:23 ` Steven Rostedt
2024-04-09 21:02 ` [POC][RFC][PATCH 2/2] pstore/ramoops: Add ramoops.mem_name= command line option Steven Rostedt
2024-04-09 22:18 ` Kees Cook
2024-04-09 23:14 ` Steven Rostedt
2024-04-09 21:23 ` [POC][RFC][PATCH 0/2] pstore/mm/x86: Add wildcard memmap to map pstore consistently Steven Rostedt
2024-04-09 22:19 ` Kees Cook
2024-04-09 22:25 ` Luck, Tony
2024-04-09 22:41 ` Joel Fernandes
2024-04-09 23:16 ` Steven Rostedt
2024-04-09 23:37 ` Kees Cook
2024-04-09 23:52 ` Luck, Tony
2024-04-11 19:11 ` Guilherme G. Piccoli
2024-04-11 19:40 ` Steven Rostedt
2024-04-12 12:17 ` Guilherme G. Piccoli
2024-04-12 17:22 ` Steven Rostedt
2024-05-01 14:45 ` Mike Rapoport
2024-05-01 14:54 ` Steven Rostedt
2024-05-01 15:30 ` Mike Rapoport
2024-05-01 16:09 ` Steven Rostedt
2024-05-01 16:11 ` Mike Rapoport
2024-05-09 4:00 ` Steven Rostedt
2024-05-09 17:31 ` Steven Rostedt
2024-05-09 20:24 ` Mike Rapoport
2024-05-09 20:33 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509163310.2aa0b2e1@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=gpiccoli@igalia.com \
--cc=hpa@zytor.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lstoakes@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=suleiman@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linuxfoundation.org \
--cc=vbabka@suse.cz \
--cc=vineeth@bitbyteword.org \
--cc=will@kernel.org \
--cc=wklin@google.com \
--cc=x86@kernel.org \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).