From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/5] tracefs: Reset permissions on remount if permissions are options
Date: Thu, 2 May 2024 11:30:03 -0400 [thread overview]
Message-ID: <20240502113003.73c0fe38@gandalf.local.home> (raw)
In-Reply-To: <20240502151620.400578783@goodmis.org>
On Thu, 02 May 2024 11:15:48 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> +/*
> + * On a remount of tracefs, if UID or GID options are set, then
> + * the mount point inode permissions should be used.
> + * Reset the saved permission flags appropriately.
> + */
> +void eventfs_remount(struct tracefs_inode *ti, bool update_uid, bool update_gid)
> +{
> + struct eventfs_inode *ei = ti->private;
And I just realized there's a race here too :-p
I need to set ti->private = NULL before freeing the ei, and probably free
the ei via RCU.
-- Steve
> +
> + if (!ei)
> + return;
> +
> + if (update_uid)
> + ei->attr.mode &= ~EVENTFS_SAVE_UID;
> +
> + if (update_gid)
> + ei->attr.mode &= ~EVENTFS_SAVE_GID;
> +
> + if (!ei->entry_attrs)
> + return;
> +
> + for (int i = 0; i < ei->nr_entries; i++) {
> + if (update_uid)
> + ei->entry_attrs[i].mode &= ~EVENTFS_SAVE_UID;
> + if (update_gid)
> + ei->entry_attrs[i].mode &= ~EVENTFS_SAVE_GID;
> + }
> +}
> +
next prev parent reply other threads:[~2024-05-02 15:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 15:15 [PATCH v2 0/5] tracefs/eventfs: Fix inconsistent permissions Steven Rostedt
2024-05-02 15:15 ` [PATCH v2 1/5] tracefs: Reset permissions on remount if permissions are options Steven Rostedt
2024-05-02 15:30 ` Steven Rostedt [this message]
2024-05-02 15:15 ` [PATCH v2 2/5] tracefs: Still use mount point as default permissions for instances Steven Rostedt
2024-05-02 15:15 ` [PATCH v2 3/5] eventfs: Do not differentiate the toplevel events directory Steven Rostedt
2024-05-02 15:15 ` [PATCH v2 4/5] eventfs: Do not treat events directory different than other directories Steven Rostedt
2024-05-02 15:15 ` [PATCH v2 5/5] eventfs: Have "events" directory get permissions from its parent Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240502113003.73c0fe38@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).