From: Steven Rostedt <rostedt@goodmis.org>
To: Pierre Gondois <pierre.gondois@arm.com>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v6 1/2] trace-cmd split: Remove const to (struct handle_list).name
Date: Thu, 22 Feb 2024 12:00:09 -0500 [thread overview]
Message-ID: <20240222120009.05cd39c3@gandalf.local.home> (raw)
In-Reply-To: <20240222165418.2153026-1-pierre.gondois@arm.com>
On Thu, 22 Feb 2024 17:54:17 +0100
Pierre Gondois <pierre.gondois@arm.com> wrote:
> (struct handle_list).name was unnecessarily made const in:
> commit caa9eda091d6 ("trace-cmd split: Store instances in local list")
>
> Remove it.
> Also fix bad indentation.
>
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
I figured I was guilty of that as well ;-)
Some of the code was probably copied and pasted from places that actually
needed it to be const.
-- Steve
prev parent reply other threads:[~2024-02-22 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 16:54 [PATCH v6 1/2] trace-cmd split: Remove const to (struct handle_list).name Pierre Gondois
2024-02-22 16:54 ` [PATCH v6 2/2] trace-cmd split: Enable support for buffer selection Pierre Gondois
2024-02-22 17:00 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240222120009.05cd39c3@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=pierre.gondois@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).