From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Stephane Eranian <eranian@google.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-toolchains@vger.kernel.org,
linux-trace-devel@vger.kernel.org,
Ben Woodard <woodard@redhat.com>, Joe Mario <jmario@redhat.com>,
Kees Cook <keescook@chromium.org>,
David Blaikie <blaikie@google.com>, Xu Liu <xliuprof@google.com>,
Kan Liang <kan.liang@linux.intel.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
Mark Wielaard <mark@klomp.org>, Jason Merrill <jason@redhat.com>,
"Jose E . Marchesi" <jose.marchesi@oracle.com>,
William Huang <williamjhuang@google.com>
Subject: [PATCHSET 00/14] perf tools: Remaining bits of data type profiling (v5)
Date: Fri, 2 Feb 2024 14:04:45 -0800 [thread overview]
Message-ID: <20240202220459.527138-1-namhyung@kernel.org> (raw)
Hello,
This is the last part of the data type profiling series.
So far we added the basic pointer variable support, and direct access to
global/local variables. Now it's time to add instruction tracking. :)
For the history and background, you can refer to the previous version
[1] and the LWN article [2].
Basically it needs to track variable (and its type) assignment to get
a type of memory access at the sampled instruction. Compilers don't
generate DWARF information for every memory accesses so it cannot find
all the necessary information from DWARF. Therefore, it follows the
path to the sample in the function, and update type information at
each location when the instruction moves it.
For the DWARF search, it has a list of scope entries (subroutines or
blocks) that covers the sample already. So it can use the scopes to
find the shortest path to the sample instruction.
Let's say we have this. It got 5 scopes but couldn't find a matching
variable for the sample.
+---------------- scope[0] subprogram
|
| +-------------- scope[1] lexical_block
| |
| | +------------ scope[2] inlined_subroutine
| | |
| | | +---------- scope[3] inlined_subroutine
| | | |
| | | | +-------- scope[4] lexical_block
| | | | |
| | | | | *** target instruction
...
Then it starts with the closest scope (at index 4), and find the
shortest path from the start of the scope to the target instruction.
Along the way, it updates type information in the scope and see if the
location at the target instruction has the type. If so, it can
return with the type.
Otherwise, it goes to the scope[3] and find the shortest path from the
start of scope[3] to the start of scope[4]. And then it can combine
the existing shortest path from the scope[4] to the target with the
new path. Now it can start from the scope[3] with new variables and
types. It can repeat this algorithm for the outer scopes.
I did it this way because mostly it was able to find a type in the
closest scope. So it can avoid unnecessary work for outer scopes.
And it added a basic per-cpu variable support for this CPU on x86_64
which uses %gs segment register. Also it can detect the stack-canary
pattern which is added by compiler to detect stack overflow.
The code is available at 'perf/data-profile-v5' branch in the tree
below. I've dropped the debug patch at the end in this series but you
can find it in the git branch.
git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
Thanks,
Namhyung
Cc: Ben Woodard <woodard@redhat.com>
Cc: Joe Mario <jmario@redhat.com>
CC: Kees Cook <keescook@chromium.org>
Cc: David Blaikie <blaikie@google.com>
Cc: Xu Liu <xliuprof@google.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Mark Wielaard <mark@klomp.org>
Cc: Jason Merrill <jason@redhat.com>
Cc: Jose E. Marchesi <jose.marchesi@oracle.com>
Cc: William Huang <williamjhuang@google.com>
[1] https://lore.kernel.org/linux-perf-users/20231110000012.3538610-1-namhyung@kernel.org/
[2] https://lwn.net/Articles/955709/
Namhyung Kim (14):
perf dwarf-aux: Add die_collect_vars()
perf dwarf-aux: Handle type transfer for memory access
perf annotate-data: Introduce struct data_loc_info
perf map: Add map__objdump_2rip()
perf annotate: Add annotate_get_basic_blocks()
perf annotate-data: Maintain variable type info
perf annotate-data: Add update_insn_state()
perf annotate-data: Handle global variable access
perf annotate-data: Handle call instructions
perf annotate-data: Implement instruction tracking
perf annotate: Parse x86 segment register location
perf annotate-data: Handle this-cpu variables in kernel
perf annotate-data: Track instructions with a this-cpu variable
perf annotate-data: Add stack canary type
tools/perf/util/annotate-data.c | 710 ++++++++++++++++++++++++++++++--
tools/perf/util/annotate-data.h | 87 +++-
tools/perf/util/annotate.c | 366 ++++++++++++++--
tools/perf/util/annotate.h | 38 ++
tools/perf/util/dwarf-aux.c | 232 +++++++++--
tools/perf/util/dwarf-aux.h | 23 ++
tools/perf/util/map.c | 20 +
tools/perf/util/map.h | 3 +
8 files changed, 1373 insertions(+), 106 deletions(-)
--
2.43.0.594.gd9cf4e227d-goog
next reply other threads:[~2024-02-02 22:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 22:04 Namhyung Kim [this message]
2024-02-02 22:04 ` [PATCH 01/14] perf dwarf-aux: Add die_collect_vars() Namhyung Kim
2024-02-02 22:04 ` [PATCH 02/14] perf dwarf-aux: Handle type transfer for memory access Namhyung Kim
2024-02-02 22:04 ` [PATCH 03/14] perf annotate-data: Introduce struct data_loc_info Namhyung Kim
2024-02-02 22:04 ` [PATCH 04/14] perf map: Add map__objdump_2rip() Namhyung Kim
2024-02-03 1:41 ` Ian Rogers
2024-02-06 23:04 ` Namhyung Kim
2024-02-06 23:33 ` Ian Rogers
2024-02-07 19:04 ` Namhyung Kim
2024-02-07 19:56 ` Ian Rogers
2024-02-07 20:43 ` Namhyung Kim
2024-02-02 22:04 ` [PATCH 05/14] perf annotate: Add annotate_get_basic_blocks() Namhyung Kim
2024-02-02 22:04 ` [PATCH 06/14] perf annotate-data: Maintain variable type info Namhyung Kim
2024-02-03 2:44 ` Ian Rogers
2024-02-06 23:06 ` Namhyung Kim
2024-02-02 22:04 ` [PATCH 07/14] perf annotate-data: Add update_insn_state() Namhyung Kim
2024-02-03 2:49 ` Ian Rogers
2024-02-06 23:07 ` Namhyung Kim
2024-02-02 22:04 ` [PATCH 08/14] perf annotate-data: Handle global variable access Namhyung Kim
2024-02-02 22:04 ` [PATCH 09/14] perf annotate-data: Handle call instructions Namhyung Kim
2024-02-03 3:09 ` Ian Rogers
2024-02-06 23:17 ` Namhyung Kim
2024-02-06 23:36 ` Ian Rogers
[not found] ` <CA+JHD91q4vA5z0g4AMPJpXV-+_ppmg6+jVu=YWcxY4hARn5LRw@mail.gmail.com>
2024-02-07 1:29 ` Namhyung Kim
2024-02-02 22:04 ` [PATCH 10/14] perf annotate-data: Implement instruction tracking Namhyung Kim
2024-02-02 22:04 ` [PATCH 11/14] perf annotate: Parse x86 segment register location Namhyung Kim
2024-02-02 22:04 ` [PATCH 12/14] perf annotate-data: Handle this-cpu variables in kernel Namhyung Kim
2024-02-02 22:04 ` [PATCH 13/14] perf annotate-data: Track instructions with a this-cpu variable Namhyung Kim
2024-02-02 22:04 ` [PATCH 14/14] perf annotate-data: Add stack canary type Namhyung Kim
2024-02-03 3:21 ` Ian Rogers
2024-02-06 23:18 ` Namhyung Kim
2024-02-06 23:40 ` Ian Rogers
2024-02-07 19:08 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240202220459.527138-1-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=blaikie@google.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jason@redhat.com \
--cc=jmario@redhat.com \
--cc=jolsa@kernel.org \
--cc=jose.marchesi@oracle.com \
--cc=kan.liang@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mark@klomp.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=torvalds@linux-foundation.org \
--cc=williamjhuang@google.com \
--cc=woodard@redhat.com \
--cc=xliuprof@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).