From: Steven Rostedt <rostedt@goodmis.org>
To: Pierre Gondois <pierre.gondois@arm.com>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v2 6/7] trace-cmd split: Enable support for buffer selection
Date: Wed, 24 Jan 2024 17:36:28 -0500 [thread overview]
Message-ID: <20240124173628.55a4f454@gandalf.local.home> (raw)
In-Reply-To: <20240124145116.55ed0432@gandalf.local.home>
On Wed, 24 Jan 2024 14:51:16 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Mon, 22 Jan 2024 17:43:35 +0100
> Pierre Gondois <pierre.gondois@arm.com> wrote:
>
> > The 'trace-cmd split' command conserves all buffers/instances
> > of the input .dat file. Add support to select the instances to
> > keep and to place as the top instance in an output .dat file.
> >
> > Multiple .dat files can be generated with different combinations
> > of the instances to keep. The first instance in the command line
> > is selected as the top instance in an output .dat file.
> >
> > For example, with a trace recorded with:
> > $ trace-cmd record -e sched_wakeup -B switch_instance \
> > -e sched_switch -B timer_instance -e timer
>
> I tried this with a trace.dat file that has a instance called "tast" and it
> didn't work. Note, the top instance had no data.
>
> $ trace-cmd split -i /work/traces/trace-tast.dat -o /tmp/trace-tast2.dat -B tast
>
> $ trace-cmd report /tmp/trace-tast2.dat
> cpus=2
> tast: trace-cmd-3559 [001] 59413.154884: sched_waking: comm=kworker/u4:2 pid=1324 prio=120 target_cpu=000
> tast: trace-cmd-3564 [000] 59413.154900: sched_switch: trace-cmd:3564 [120] R ==> kworker/u4:2:1324 [120]
> tast: trace-cmd-3559 [001] 59413.154907: sched_switch: trace-cmd:3559 [120] S ==> trace-cmd:3565 [120]
> tast: kworker/u4:2-1324 [000] 59413.154911: sched_waking: comm=sshd pid=18725 prio=120 target_cpu=001
> tast: kworker/u4:2-1324 [000] 59413.154929: sched_switch: kworker/u4:2:1324 [120] I ==> sshd:18725 [120]
> tast: sshd-18725 [000] 59413.155120: sched_waking: comm=sslh-fork pid=18724 prio=120 target_cpu=001
> tast: sshd-18725 [000] 59413.155178: sched_waking: comm=kworker/0:1 pid=815 prio=120 target_cpu=000
> tast: sshd-18725 [000] 59413.155189: sched_switch: sshd:18725 [120] S ==> sslh-fork:18724 [120]
> tast: sslh-fork-18724 [000] 59413.155303: sched_switch: sslh-fork:18724 [120] S ==> kworker/0:1:815 [120]
>
> Still has "tast" as an instance and not the top.
I replied to the wrong email. This should have been sent to the v3 version.
-- Steve
next prev parent reply other threads:[~2024-01-24 22:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 16:43 [PATCH v2 0/7] trace-cmd: split: Handle splitting files with multiple instances Pierre Gondois
2024-01-22 16:43 ` [PATCH v2 1/7] trace-cmd split: Small fixes Pierre Gondois
2024-01-22 16:43 ` [PATCH v2 2/7] trace-cmd split: Correctly split with start/end/time-window parameters Pierre Gondois
2024-01-23 1:51 ` Steven Rostedt
2024-01-24 17:28 ` Steven Rostedt
2024-01-22 16:43 ` [PATCH v2 3/7] trace-cmd split: Store instances in local list Pierre Gondois
2024-01-23 0:17 ` Steven Rostedt
2024-01-22 16:43 ` [PATCH v2 4/7] trace-cmd split: Add functions to generate temp files Pierre Gondois
2024-01-23 0:20 ` Steven Rostedt
2024-01-22 16:43 ` [PATCH v2 5/7] trace-cmd split: Handle splitting files with multiple instances Pierre Gondois
2024-01-23 0:23 ` Steven Rostedt
2024-01-23 13:44 ` Pierre Gondois
2024-01-22 16:43 ` [PATCH v2 6/7] trace-cmd split: Enable support for buffer selection Pierre Gondois
2024-01-24 19:51 ` Steven Rostedt
2024-01-24 22:36 ` Steven Rostedt [this message]
2024-01-22 16:43 ` [PATCH v2 7/7] trace-cmd split: Update usage Pierre Gondois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240124173628.55a4f454@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=pierre.gondois@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).