From: Steven Rostedt <rostedt@goodmis.org>
To: Ross Zwisler <zwisler@google.com>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>,
Stevie Alvarez <stevie.6strings@gmail.com>
Subject: Re: [PATCH] libtraceeval: Use trick to force static array usage where needed
Date: Thu, 5 Oct 2023 17:59:54 -0400 [thread overview]
Message-ID: <20231005175954.77c6c1da@gandalf.local.home> (raw)
In-Reply-To: <20231005212521.GA3146009@google.com>
On Thu, 5 Oct 2023 15:25:21 -0600
Ross Zwisler <zwisler@google.com> wrote:
> That's some scary deep magic. :)
Yeah it is. Hence the detailed change log, and not just:
"The macro prevents static traceeval_data *keys from being used"
>
> We may want to add a comment above this to briefly explain, i.e. "This macro
> will fail to build if 'data' is a pointer and not a static array" and refer
> them to the commit history? That way they have some way to proceed if/when
> their build fails.
Well, I don't think they need to understand how the macro work. But just
why it failed. Even though new compilers also warn about why it doesn't
work, I can still add:
/*
* If your compile failed due to the below macro, it is likely you used
* a pointer to struct traceeval_data, and not a static array.
*
* That is:
*
* struct traceeval_data *keys;
*
* and not:
*
* struct traceeval_data keys[] = { ... };
*/
I'll send a v2
>
> Otherwise looks good:
> Reviewed-by: Ross Zwisler <zwisler@google.com>
Thanks!
-- Steve
prev parent reply other threads:[~2023-10-05 21:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 22:52 [PATCH] libtraceeval: Use trick to force static array usage where needed Steven Rostedt
2023-10-05 21:25 ` Ross Zwisler
2023-10-05 21:59 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231005175954.77c6c1da@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=stevie.6strings@gmail.com \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).