From: Steven Rostedt <rostedt@goodmis.org>
To: Ross Zwisler <zwisler@google.com>
Cc: linux-trace-devel@vger.kernel.org,
Stevie Alvarez <stevie.6strings@gmail.com>
Subject: Re: [PATCH 0/2] libtraceeval: Remove the need of TRACEEVAL_TYPE_NONE
Date: Tue, 3 Oct 2023 09:48:04 -0400 [thread overview]
Message-ID: <20231003094804.77078cb6@gandalf.local.home> (raw)
In-Reply-To: <20231002211826.GO1532181@google.com>
On Mon, 2 Oct 2023 15:18:26 -0600
Ross Zwisler <zwisler@google.com> wrote:
> > Looks good, you can add:
> > Reviewed-by: Ross Zwisler <zwisler@google.com>
>
> Actually, I think we need to make similar updates in check_keys() and
> check_vals(), else calls to traceeval_init_data_size() will walk off the end
> of those respective arrays.
Good catch! I'm surprised this didn't crash it my testing. Maybe it as just
aligned in a way that there was a NULL after it.
-- Steve
prev parent reply other threads:[~2023-10-03 13:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 10:00 [PATCH 0/2] libtraceeval: Remove the need of TRACEEVAL_TYPE_NONE Steven Rostedt
2023-09-29 10:00 ` [PATCH 1/2] libtraceeval: Remove need to use TRACEEVAL_TYPE_NONE in keys and vals Steven Rostedt
2023-09-29 10:00 ` [PATCH 2/2] libtraceeval samples: Remove adding TRACEEVAL_TYPE_NONE to " Steven Rostedt
2023-10-02 21:07 ` [PATCH 0/2] libtraceeval: Remove the need of TRACEEVAL_TYPE_NONE Ross Zwisler
2023-10-02 21:18 ` Ross Zwisler
2023-10-03 13:48 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003094804.77078cb6@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=stevie.6strings@gmail.com \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).