From: Ross Zwisler <zwisler@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org,
Stevie Alvarez <stevie.6strings@gmail.com>
Subject: Re: [PATCH v4 00/20] libtraceeval histogram: Updates
Date: Thu, 17 Aug 2023 14:59:08 -0600 [thread overview]
Message-ID: <20230817205908.GD73817@google.com> (raw)
In-Reply-To: <20230817204528.114577-1-rostedt@goodmis.org>
On Thu, Aug 17, 2023 at 04:45:08PM -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
>
> This patch set is based on top of:
>
> https://lore.kernel.org/all/20230809175340.3066-1-stevie.6strings@gmail.com/
>
> I added a sample program task-eval which is one of the tools that will be
> using this library. The first patch adds task-eval but that is still using
> the old API (defined in trace-analysis.c).
>
> The next patches modify the new API to fit with the use case of task-eval.
> One is to use "pointer" as I'm not sure exactly the usecase of the dynamic
> structure.
>
> The cmp and release callbacks are changed to be more generic, and they get
> called if they simply exist for a given type. I can imagine wanting a
> release function for event the most mundane types (like number_32).
>
> The cmp was also updated to pass in the traceeval descriptor, as I found
> that I needed access to it while doing a compare (although, I rewrote the
> code a bit where that use case isn't in the tool anymore).
>
> Some fixes were made to the query.
>
> I also did a bit of code restructuring and add the hash and iterator logic.
>
> The last patch updates the sample code task-eval.c and has it give pretty
> much the same logic as the original.
>
> That sample could be updated to implement the code consolidation that Ross
> suggested. I may do that later.
>
> Happy programming!
Looks good, you can add:
Reviewed-by: Ross Zwisler <zwisler@google.com>
>
> Changes since v3: https://lore.kernel.org/all/20230817013310.88582-1-rostedt@goodmis.org/
>
> - Added patch to reordered the parameters of copy_traceeval_data() and renamed
> copy to dst and orig to src to match that of memcpy() and strcpy().
>
> - Added patch to rename copy_traceeval_data_set() to dup_traceeval_data_set()
> to not have the parameter order to be confusing with the typical copy order.
>
> - Fixed comment of traceeval_remove() (Ross Zwisler)
>
> Changes since v2: https://lore.kernel.org/all/20230811053940.1408424-1-rostedt@goodmis.org/
>
> - Fixed comments on traceeval_dyn_release_fn and traceeval_dyn_cmp_fn (Ross Zwisler)
>
> - Change parameter ordering of compare_traceeval_data (Ross Zwisler)
>
> - Added (size_t) to offset_of() macro (Ross Zwisler)
>
> - Fixed iter->current_bucket off by one bug (Ross Zwisler)
>
> - Removed HASH_MASK() from make_hash()
>
> - Fixed goto fail_release in traceeval_init() (Ross Zwisler)
>
> - Free sort and direction in traceeval_iterator_put() (Ross Zwisler)
>
> - Use num_levels variable instead of (level + 1) (Ross Zwisler)
>
> - Return 0 on success of update_entry (Ross Zwisler)
>
> - Fixed the cleanup of old values in update_entry() (Ross Zwisler)
>
> - Fixed resetting iter->next = 0 in traceeval_iterator_sort_custom() (Ross Zwisler)
>
> - Added failure checks to task-eval.c sample for all traceeval_query() calls.
>
> - Added traceeval_remove() to remove an item from traceveal (opposite of traceeval_insert())
>
> Changes since v1: https://lore.kernel.org/all/20230809031313.1298605-1-rostedt@goodmis.org/
>
> - Lots!
>
> - Converted to using a hash table
>
> - Removed the unused compare code. With the other updates, it was
> taking too much time to keep updating them.
>
> - Added checks and labels to the types to have them know what type
> they are, and index they are at.
>
> - Added stat logic
>
> - Added iterator logic
>
> - Have a working sample with the new code!
>
> Steven Rostedt (Google) (20):
> libtraceeval histograms: Fix traceeval_results_release() error message
> libtraceeval: Reverse params of copy_traceeval_data()
> libtraceeval: Rename copy_traceeval_data_set() to dup_traceeval_data()
> libtraceeval: Add sample task-eval program
> libtraceeval hist: Add pointer and const string types
> libtraceeval histogram: Have cmp and release functions be generic
> libtraceeval histograms: Add traceeval struct to compare function
> libtraceeval histogram: Remove comparing of traceeval and types
> libtraceeval: Convert hist array into a hash table
> libtraceeval histograms: Move hash functions into their own file
> libtraceeval histogram: Label and check keys and values
> libtraceeval histogram: Add updating of stats
> libtraceeval histogram: Add iterator APIs
> libtraceeval histogram: Add data copy callback
> libtraceeval histogram: Do the release on updates
> libtraceeval histogram: Use stack for old copy in update
> libtraceeval histogram: Add traceeval_iterator_sort_custom()
> libtraceeval histogram: Have traceeval_query() just give the pointer
> to results
> libtraceeval samples: Update task-eval to use the histogram logic
> libtraceeval: Add traceeval_remove()
>
> Makefile | 4 +-
> include/traceeval-hist.h | 117 +++--
> include/traceeval-test.h | 16 -
> samples/Makefile | 29 ++
> samples/task-eval.c | 966 +++++++++++++++++++++++++++++++++++++++
> src/Makefile | 1 +
> src/eval-local.h | 123 +++++
> src/hash.c | 123 +++++
> src/histograms.c | 945 ++++++++++++++++++++++++++++----------
> 9 files changed, 2023 insertions(+), 301 deletions(-)
> delete mode 100644 include/traceeval-test.h
> create mode 100644 samples/Makefile
> create mode 100644 samples/task-eval.c
> create mode 100644 src/eval-local.h
> create mode 100644 src/hash.c
>
> --
> 2.40.1
>
prev parent reply other threads:[~2023-08-17 21:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 20:45 [PATCH v4 00/20] libtraceeval histogram: Updates Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 01/20] libtraceeval histograms: Fix traceeval_results_release() error message Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 02/20] libtraceeval: Reverse params of copy_traceeval_data() Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 03/20] libtraceeval: Rename copy_traceeval_data_set() to dup_traceeval_data() Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 04/20] libtraceeval: Add sample task-eval program Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 05/20] libtraceeval hist: Add pointer and const string types Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 06/20] libtraceeval histogram: Have cmp and release functions be generic Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 07/20] libtraceeval histograms: Add traceeval struct to compare function Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 08/20] libtraceeval histogram: Remove comparing of traceeval and types Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 09/20] libtraceeval: Convert hist array into a hash table Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 10/20] libtraceeval histograms: Move hash functions into their own file Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 11/20] libtraceeval histogram: Label and check keys and values Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 12/20] libtraceeval histogram: Add updating of stats Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 13/20] libtraceeval histogram: Add iterator APIs Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 14/20] libtraceeval histogram: Add data copy callback Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 15/20] libtraceeval histogram: Do the release on updates Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 16/20] libtraceeval histogram: Use stack for old copy in update Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 17/20] libtraceeval histogram: Add traceeval_iterator_sort_custom() Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 18/20] libtraceeval histogram: Have traceeval_query() just give the pointer to results Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 19/20] libtraceeval samples: Update task-eval to use the histogram logic Steven Rostedt
2023-08-17 20:45 ` [PATCH v4 20/20] libtraceeval: Add traceeval_remove() Steven Rostedt
2023-08-17 20:48 ` [PATCH v4 00/20] libtraceeval histogram: Updates Steven Rostedt
2023-08-17 20:59 ` Ross Zwisler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230817205908.GD73817@google.com \
--to=zwisler@google.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=stevie.6strings@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).