From: Steven Rostedt <rostedt@goodmis.org>
To: Ross Zwisler <zwisler@google.com>
Cc: linux-trace-devel@vger.kernel.org,
Stevie Alvarez <stevie.6strings@gmail.com>
Subject: Re: [PATCH v3 00/18] libtraceeval histogram: Updates
Date: Thu, 17 Aug 2023 16:37:49 -0400 [thread overview]
Message-ID: <20230817163749.3d5404bf@gandalf.local.home> (raw)
In-Reply-To: <20230817163119.6cdde89a@gandalf.local.home>
On Thu, 17 Aug 2023 16:31:19 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 17 Aug 2023 14:13:52 -0600
> Ross Zwisler <zwisler@google.com> wrote:
>
> > > - Added traceeval_remove() to remove an item from traceveal (opposite of traceeval_insert())
> >
> > I think you've addressed all my review comments, you can add:
> >
> > Reviewed-by: Ross Zwisler <zwisler@google.com>
> >
> > to the series. Thanks!
>
> Thanks for taking the time Ross. I'll be posting v4 soon, and hopefully
> I'll be able to add that.
>
> Then I have yet another series on top of that!!
Because I did some changes to the parameters at the beginning, it caused
conflicts through out. I'll post the v4 before adding your Reviewed-by tag,
just so you can have one last look at it (I added two patches to do the
rename and reorder of the parameters).
-- Steve
prev parent reply other threads:[~2023-08-17 20:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 1:32 [PATCH v3 00/18] libtraceeval histogram: Updates Steven Rostedt
2023-08-17 1:32 ` [PATCH v3 01/18] libtraceeval histograms: Fix traceeval_results_release() error message Steven Rostedt
2023-08-17 1:32 ` [PATCH v3 02/18] libtraceeval: Add sample task-eval program Steven Rostedt
2023-08-17 1:32 ` [PATCH v3 03/18] libtraceeval hist: Add pointer and const string types Steven Rostedt
2023-08-17 1:32 ` [PATCH v3 04/18] libtraceeval histogram: Have cmp and release functions be generic Steven Rostedt
2023-08-17 1:32 ` [PATCH v3 05/18] libtraceeval histograms: Add traceeval struct to compare function Steven Rostedt
2023-08-17 1:32 ` [PATCH v3 06/18] libtraceeval histogram: Remove comparing of traceeval and types Steven Rostedt
2023-08-17 1:32 ` [PATCH v3 07/18] libtraceeval: Convert hist array into a hash table Steven Rostedt
2023-08-17 1:33 ` [PATCH v3 08/18] libtraceeval histograms: Move hash functions into their own file Steven Rostedt
2023-08-17 1:33 ` [PATCH v3 09/18] libtraceeval histogram: Label and check keys and values Steven Rostedt
2023-08-17 1:33 ` [PATCH v3 10/18] libtraceeval histogram: Add updating of stats Steven Rostedt
2023-08-17 1:33 ` [PATCH v3 11/18] libtraceeval histogram: Add iterator APIs Steven Rostedt
2023-08-17 1:33 ` [PATCH v3 12/18] libtraceeval histogram: Add data copy callback Steven Rostedt
2023-08-17 1:33 ` [PATCH v3 13/18] libtraceeval histogram: Do the release on updates Steven Rostedt
2023-08-17 1:33 ` [PATCH v3 14/18] libtraceeval histogram: Use stack for old copy in update Steven Rostedt
2023-08-17 19:29 ` Ross Zwisler
2023-08-17 19:42 ` Steven Rostedt
2023-08-17 19:44 ` Ross Zwisler
2023-08-17 20:25 ` Steven Rostedt
2023-08-17 1:33 ` [PATCH v3 15/18] libtraceeval histogram: Add traceeval_iterator_sort_custom() Steven Rostedt
2023-08-17 1:33 ` [PATCH v3 16/18] libtraceeval histogram: Have traceeval_query() just give the pointer to results Steven Rostedt
2023-08-17 1:33 ` [PATCH v3 17/18] libtraceeval samples: Update task-eval to use the histogram logic Steven Rostedt
2023-08-17 1:33 ` [PATCH v3 18/18] libtraceeval: Add traceeval_remove() Steven Rostedt
2023-08-17 20:12 ` Ross Zwisler
2023-08-17 1:35 ` [PATCH v3 00/18] libtraceeval histogram: Updates Steven Rostedt
2023-08-17 20:13 ` Ross Zwisler
2023-08-17 20:31 ` Steven Rostedt
2023-08-17 20:37 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230817163749.3d5404bf@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=stevie.6strings@gmail.com \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).