From: Steven Rostedt <rostedt@goodmis.org>
To: Ross Zwisler <zwisler@google.com>
Cc: linux-trace-devel@vger.kernel.org,
Stevie Alvarez <stevie.6strings@gmail.com>
Subject: Re: [PATCH v2 14/17] libtraceeval histogram: Use stack for old copy in update
Date: Wed, 16 Aug 2023 21:13:30 -0400 [thread overview]
Message-ID: <20230816211330.7f6e2cb3@gandalf.local.home> (raw)
In-Reply-To: <20230816191225.7e3e7d85@gandalf.local.home>
On Wed, 16 Aug 2023 19:12:25 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> > > +
> > > + for (i = 0; i < size; i++) {
> > > + old[i] = copy[i];
> > > +
> > > + if (copy_traceeval_data(types + i, stats + i,
> > > + vals + i, copy + i))
> > > + goto fail;
> > > + }
> >
> > I think we still need to rip through old[] and free strings, and also call
>
> Yes, I forgot to add that :-p
>
> > .release on types that define it, probably via data_release().
> >
I realized I actually had this kind of backwards. On failure, we want to put
back old and remove the data added to vals (aka copy).
Here's what I'm doing:
for (i = 0; i < size; i++) {
old[i] = copy[i];
if (copy_traceeval_data(types + i, stats + i,
vals + i, copy + i))
goto fail;
}
data_release(size, old, types);
return 0;
fail:
/* Free the new values that were added */
data_release(i, copy, types);
/* Put back the old values */
for (i--; i >= 0; i--) {
copy_traceeval_data(types + i, NULL,
copy + i, old + i);
}
return -1;
-- Steve
next prev parent reply other threads:[~2023-08-17 1:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 5:39 [PATCH v2 00/17] libtraceeval histogram: Updates Steven Rostedt
2023-08-11 5:39 ` [PATCH v2 01/17] libtraceeval histograms: Fix traceeval_results_release() error message Steven Rostedt
2023-08-11 5:39 ` [PATCH v2 02/17] libtraceeval: Add sample task-eval program Steven Rostedt
2023-08-11 5:39 ` [PATCH v2 03/17] libtraceeval hist: Add pointer and const string types Steven Rostedt
2023-08-11 5:39 ` [PATCH v2 04/17] libtraceeval histogram: Have cmp and release functions be generic Steven Rostedt
2023-08-15 16:50 ` Ross Zwisler
2023-08-15 18:52 ` Steven Rostedt
2023-08-11 5:39 ` [PATCH v2 05/17] libtraceeval histograms: Add traceeval struct to compare function Steven Rostedt
2023-08-15 16:55 ` Ross Zwisler
2023-08-15 18:53 ` Steven Rostedt
2023-08-11 5:39 ` [PATCH v2 06/17] libtraceeval histogram: Remove comparing of traceeval and types Steven Rostedt
2023-08-11 5:39 ` [PATCH v2 07/17] libtraceeval: Convert hist array into a hash table Steven Rostedt
2023-08-15 18:44 ` Ross Zwisler
2023-08-15 19:05 ` Steven Rostedt
2023-08-11 5:39 ` [PATCH v2 08/17] libtraceeval histograms: Move hash functions into their own file Steven Rostedt
2023-08-15 19:31 ` Ross Zwisler
2023-08-15 20:23 ` Steven Rostedt
2023-08-15 22:56 ` Steven Rostedt
2023-08-11 5:39 ` [PATCH v2 09/17] libtraceeval histogram: Label and check keys and values Steven Rostedt
2023-08-15 19:48 ` Ross Zwisler
2023-08-15 20:24 ` Steven Rostedt
2023-08-11 5:39 ` [PATCH v2 10/17] libtraceeval histogram: Add updating of stats Steven Rostedt
2023-08-15 20:25 ` Ross Zwisler
2023-08-15 20:55 ` Steven Rostedt
2023-08-11 5:39 ` [PATCH v2 11/17] libtraceeval histogram: Add iterator APIs Steven Rostedt
2023-08-16 21:34 ` Ross Zwisler
2023-08-16 21:49 ` Steven Rostedt
2023-08-11 5:39 ` [PATCH v2 12/17] libtraceeval histogram: Add data copy callback Steven Rostedt
2023-08-11 5:39 ` [PATCH v2 13/17] libtraceeval histogram: Do the release on updates Steven Rostedt
2023-08-11 5:39 ` [PATCH v2 14/17] libtraceeval histogram: Use stack for old copy in update Steven Rostedt
2023-08-16 22:37 ` Ross Zwisler
2023-08-16 23:12 ` Steven Rostedt
2023-08-17 1:03 ` Steven Rostedt
2023-08-17 1:13 ` Steven Rostedt [this message]
2023-08-11 5:39 ` [PATCH v2 15/17] libtraceeval histogram: Add traceeval_iterator_sort_custom() Steven Rostedt
2023-08-16 22:57 ` Ross Zwisler
2023-08-16 23:22 ` Steven Rostedt
2023-08-11 5:39 ` [PATCH v2 16/17] libtraceeval histogram: Have traceeval_query() just give the pointer to results Steven Rostedt
2023-08-11 5:39 ` [PATCH v2 17/17] libtraceeval samples: Update task-eval to use the histogram logic Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230816211330.7f6e2cb3@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=stevie.6strings@gmail.com \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).