From: Steven Rostedt <rostedt@goodmis.org>
To: Stevie Alvarez <stevie.6strings@gmail.com>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>,
Ross Zwisler <zwisler@google.com>
Subject: Re: [PATCH] libtraceeval histogram: Add type to traceeval_data and make it a structure
Date: Wed, 16 Aug 2023 12:24:50 -0400 [thread overview]
Message-ID: <20230816122450.53b10856@gandalf.local.home> (raw)
In-Reply-To: <20230816154145.GA1462@3xKetch>
On Wed, 16 Aug 2023 11:41:45 -0400
Stevie Alvarez <stevie.6strings@gmail.com> wrote:
> > void set_process_data(struct task_data *tdata, const char *comm, void *data)
> > {
> > - union traceeval_data keys[] = {
> > + struct traceeval_data keys[] = {
> > {
> > .cstring = comm,
> > },
>
> Is there a reason you stop using the macros to define your
> traceeval_data array elements? Or a better question: Are these struct
> traceeval_data instances exempt to needing a type field? And if so, why?
No reason, I just missed this. I've updated it in my code and have a v2
ready to post. I just tested by compiling it. When I actually ran the code
(after posting the patches), it didn't give the same output, and found that
this was why :-p
-- Steve
prev parent reply other threads:[~2023-08-16 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 23:38 [PATCH] libtraceeval histogram: Add type to traceeval_data and make it a structure Steven Rostedt
2023-08-16 15:41 ` Stevie Alvarez
2023-08-16 16:24 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230816122450.53b10856@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=stevie.6strings@gmail.com \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).