From: Stevie Alvarez <stevie.6strings@gmail.com>
To: linux-trace-devel@vger.kernel.org
Cc: Stevie Alvarez <stevie.6strings@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ross Zwisler <zwisler@google.com>
Subject: [PATCH v4 0/5] histograms: Fix memory leak, logic bugs, legibility
Date: Wed, 9 Aug 2023 13:53:33 -0400 [thread overview]
Message-ID: <20230809175340.3066-1-stevie.6strings@gmail.com> (raw)
From: Stevie Alvarez (Google) <stevie.6strings@gmail.com>
Changes in v4:
* Reorder enum traceeval_data_type numeric types for algorithmic access.
* Reorder union traceeval_data numeric fields for legibility.
* Remove parenthesis from function name in kerneldocs.
* Optimize logic in type_alloc().
* Distinguish internal vs public interfaces within include statements.
* Rework copy_traceeval_data() logic for legibility.
* Rework comparator return types to fix query and insert bugs.
* update_entry() frees the entries old values to avoid a memory leak.
Steven, I didn't get around to adding in the cstring field to
traceeval_data, as I wasn't able to completely grasp what you were
looking for. My apologies.
---
v3 discussion: https://lore.kernel.org/linux-trace-devel/20230808180156.GA1300@3xKetch/T/#t
Stevie Alvarez (Google) (5):
histograms: Initial histograms interface
histograms: Add traceeval initialize and release
histograms: Add traceeval compare
histograms: Add traceeval query
histograms: Add traceeval insert
Makefile | 2 +-
include/traceeval-hist.h | 147 +++++++
include/traceeval-test.h | 16 +
src/Makefile | 1 +
src/histograms.c | 804 +++++++++++++++++++++++++++++++++++++++
5 files changed, 969 insertions(+), 1 deletion(-)
create mode 100644 include/traceeval-hist.h
create mode 100644 include/traceeval-test.h
create mode 100644 src/histograms.c
--
2.41.0
next reply other threads:[~2023-08-09 17:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 17:53 Stevie Alvarez [this message]
2023-08-09 17:53 ` [PATCH v4 1/5] histograms: Initial histograms interface Stevie Alvarez
2023-08-09 18:53 ` Steven Rostedt
2023-08-09 17:53 ` [PATCH v4 2/5] histograms: Add traceeval initialize and release Stevie Alvarez
2023-08-09 19:04 ` Steven Rostedt
2023-08-09 17:53 ` [PATCH v4 3/5] histograms: Add traceeval compare Stevie Alvarez
2023-08-09 17:53 ` [PATCH v4 4/5] histograms: Add traceeval query Stevie Alvarez
2023-08-09 19:57 ` Steven Rostedt
2023-08-11 2:00 ` Steven Rostedt
2023-08-09 17:53 ` [PATCH v4 5/5] histograms: Add traceeval insert Stevie Alvarez
2023-08-10 2:57 ` Steven Rostedt
2023-08-09 18:30 ` [PATCH v4 0/5] histograms: Fix memory leak, logic bugs, legibility Steven Rostedt
2023-08-10 21:16 ` Ross Zwisler
2023-08-17 22:08 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230809175340.3066-1-stevie.6strings@gmail.com \
--to=stevie.6strings@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).