From: Ross Zwisler <zwisler@kernel.org>
To: linux-trace-devel@vger.kernel.org
Cc: Ross Zwisler <zwisler@google.com>,
"Stevie Alvarez (Google)" <stevie.6strings@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: [PATCH] libtraceeval: fix cscope makefile rule
Date: Wed, 2 Aug 2023 11:16:34 -0600 [thread overview]
Message-ID: <20230802171637.3121112-1-zwisler@kernel.org> (raw)
From: Ross Zwisler <zwisler@google.com>
The current 'make cscope' rule does not actually pass the filenames
gathered by 'find' to cscope. cscope expects them either to be passed
on the command line, as this patch does with xargs, or via a
'cscope.files' intermediate file. It doesn't read them from stdin.
As long as the file count is low, as it is in this library, the command
line version works fine. Larger projects like the kernel need to use
the intermediate file.
Signed-off-by: Ross Zwisler <zwisler@google.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 3ea051c..5779c43 100644
--- a/Makefile
+++ b/Makefile
@@ -230,7 +230,7 @@ $(EMACS_TAGS): force
$(CSCOPE_TAGS): force
$(RM) $(obj)/cscope*
- $(call find_tag_files) | cscope -b -q
+ $(call find_tag_files) | xargs cscope -b -q
tags: $(VIM_TAGS)
TAGS: $(EMACS_TAGS)
--
2.41.0.585.gd2178a4bd4-goog
reply other threads:[~2023-08-02 17:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802171637.3121112-1-zwisler@kernel.org \
--to=zwisler@kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=stevie.6strings@gmail.com \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).