From: Viresh Kumar <viresh.kumar@linaro.org>
To: Lizhe <sensor1010@163.com>
Cc: rafael@kernel.org, ray.huang@amd.com, marcan@marcan.st,
sven@svenpeter.dev, alyssa@rosenzweig.io, mmayer@broadcom.com,
bcm-kernel-feedback-list@broadcom.com,
srinivas.pandruvada@linux.intel.com, lenb@kernel.org,
khilman@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org,
naveen.n.rao@linux.ibm.com, andersson@kernel.org,
konrad.dybcio@linaro.org, sudeep.holla@arm.com,
cristian.marussi@arm.com, thierry.reding@gmail.com,
jonathanh@nvidia.com, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] cpufreq: Covert to exit callback returning void
Date: Fri, 12 Apr 2024 11:32:53 +0530 [thread overview]
Message-ID: <20240412060253.5zzc72mkmmz3xr72@vireshk-i7> (raw)
In-Reply-To: <20240410132247.3587-1-sensor1010@163.com>
On 10-04-24, 06:22, Lizhe wrote:
> For the exit() callback function returning an int type value.
> this leads many driver authors mistakenly believing that error
> handling can be performed by returning an error code. However.
> the returned value is ignore, and to improve this situation.
> it is proposed to modify the return type of the exit() callback
> function to void
>
> Signed-off-by: Lizhe <sensor1010@163.com>
> ---
> drivers/cpufreq/acpi-cpufreq.c | 4 +---
> drivers/cpufreq/amd-pstate.c | 7 ++-----
> drivers/cpufreq/apple-soc-cpufreq.c | 4 +---
> drivers/cpufreq/bmips-cpufreq.c | 4 +---
> drivers/cpufreq/cppc_cpufreq.c | 3 +--
> drivers/cpufreq/cpufreq-dt.c | 3 +--
> drivers/cpufreq/e_powersaver.c | 3 +--
> drivers/cpufreq/intel_pstate.c | 4 +---
> drivers/cpufreq/mediatek-cpufreq-hw.c | 4 +---
> drivers/cpufreq/mediatek-cpufreq.c | 4 +---
> drivers/cpufreq/omap-cpufreq.c | 3 +--
> drivers/cpufreq/pasemi-cpufreq.c | 6 ++----
> drivers/cpufreq/powernow-k6.c | 3 +--
> drivers/cpufreq/powernow-k7.c | 3 +--
> drivers/cpufreq/powernow-k8.c | 4 +---
> drivers/cpufreq/powernv-cpufreq.c | 4 +---
> drivers/cpufreq/ppc_cbe_cpufreq.c | 3 +--
> drivers/cpufreq/qcom-cpufreq-hw.c | 4 +---
> drivers/cpufreq/qoriq-cpufreq.c | 4 +---
> drivers/cpufreq/scmi-cpufreq.c | 4 +---
> drivers/cpufreq/scpi-cpufreq.c | 4 +---
> drivers/cpufreq/sh-cpufreq.c | 4 +---
> drivers/cpufreq/sparc-us2e-cpufreq.c | 3 +--
> drivers/cpufreq/sparc-us3-cpufreq.c | 3 +--
> drivers/cpufreq/speedstep-centrino.c | 4 +---
> drivers/cpufreq/tegra194-cpufreq.c | 4 +---
> drivers/cpufreq/vexpress-spc-cpufreq.c | 3 +--
> 27 files changed, 29 insertions(+), 74 deletions(-)
I have discarded all emails with following subject line:
"cpufreq: Convert to exit callback returning void".
While you have sent decent patches for removing the empty exit callbacks, the
way you have handled these changes is not correct.
Don't send any patches for now and please wait and understand what's being asked
from you.
This change you are trying to make is okay and sensible, but you can not send
random patches to the list just like that. You are wasting everyone's time here
including yourself.
Now what we expect here is a single commit (with version history), which changes
all the users of the exit() function (each and every cpufreq driver) and
cpufreq.h and cpufreq.c. That change should compile fine and break none of the
platforms compilation.
Please don't send more of these patches unless this is done.
--
viresh
next prev parent reply other threads:[~2024-04-12 6:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 13:22 [PATCH] cpufreq: Covert to exit callback returning void Lizhe
[not found] ` <279401246.446176.1712756559290.JavaMail.root@mail-tracker-145-3ep34-c9h23-5f64cf7787-82gdh>
2024-04-10 13:55 ` Christophe Leroy
[not found] ` <1388632395.447003.1712759604593.JavaMail.root@mail-tracker-145-3ep34-c9h23-5f64cf7787-82gdh>
2024-04-10 17:19 ` Florian Fainelli
2024-04-12 6:02 ` Viresh Kumar [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-10 13:21 Lizhe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412060253.5zzc72mkmmz3xr72@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=alyssa@rosenzweig.io \
--cc=andersson@kernel.org \
--cc=aneesh.kumar@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=asahi@lists.linux.dev \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=christophe.leroy@csgroup.eu \
--cc=cristian.marussi@arm.com \
--cc=jonathanh@nvidia.com \
--cc=khilman@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=marcan@marcan.st \
--cc=matthias.bgg@gmail.com \
--cc=mmayer@broadcom.com \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=sensor1010@163.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=sudeep.holla@arm.com \
--cc=sven@svenpeter.dev \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).