From: Chris Morgan <macromorgan@hotmail.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Chris Morgan <macroalpha82@gmail.com>,
linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org,
mripard@kernel.org, samuel@sholland.org,
jernej.skrabec@gmail.com, wens@csie.org, conor+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh@kernel.org,
ryan@testtoast.com
Subject: Re: [PATCH 2/2] arm64: dts: allwinner: h616: Add NMI device node
Date: Thu, 18 Apr 2024 12:52:44 -0500 [thread overview]
Message-ID: <DM4PR05MB9229EECD9B39729F8DE0F786A50E2@DM4PR05MB9229.namprd05.prod.outlook.com> (raw)
In-Reply-To: <20240418171907.27c0ef84@donnerap.manchester.arm.com>
On Thu, Apr 18, 2024 at 05:19:07PM +0100, Andre Przywara wrote:
> On Thu, 18 Apr 2024 10:59:13 -0500
> Chris Morgan <macromorgan@hotmail.com> wrote:
>
> Hi,
>
> > On Mon, Apr 15, 2024 at 12:37:40AM +0100, Andre Przywara wrote:
> > > On Sun, 14 Apr 2024 12:04:24 -0500
> > > Chris Morgan <macroalpha82@gmail.com> wrote:
> > >
> > > Hi Chris,
> > >
> > > > From: Chris Morgan <macromorgan@hotmail.com>
> > > >
> > > > Add device node for the H616 Non Maskable Interrupt (NMI) controller.
> > >
> > > You might want to mention that the NMI pad is not exposed on the H616 variants, but on
> > > the T507 and H700 packages.
> > >
> > > >
> > > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> > > > ---
> > > > arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 9 +++++++++
> > > > 1 file changed, 9 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> > > > index b2e85e52d1a1..1e066f3057be 100644
> > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> > > > @@ -775,6 +775,15 @@ r_ccu: clock@7010000 {
> > > > #reset-cells = <1>;
> > > > };
> > > >
> > > > + nmi_intc: interrupt-controller@7010320 {
> > > > + compatible = "allwinner,sun50i-h616-nmi",
> > > > + "allwinner,sun9i-a80-nmi";
> > > > + reg = <0x07010320 0xc>;
> > > > + interrupt-controller;
> > > > + #interrupt-cells = <2>;
> > > > + interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
> > > > + };
> > > > +
> > >
> > > I can confirm that this matches the manual, and the registers behave as
> > > described in the A80 manual. I don't have access to a chip with the NMI
> > > pad exposed or used, so I cannot test this fully, but Chris'
> > > experiments with the AXP717 PMIC connected to that pin on on H700
> > > board seem to confirm that it indeed works.
> > >
> > > So with that small amendment to the commit message please take my:
> > >
> > > Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> > >
> > > Cheers,
> > > Andre
> > >
> > > > r_pio: pinctrl@7022000 {
> > > > compatible = "allwinner,sun50i-h616-r-pinctrl";
> > > > reg = <0x07022000 0x400>;
> > >
> >
> > Since the H616 doesn't have this functionality but the T507 and H700
> > does, should I change the compatible string? It's all the same
> > silicon die with just a different part number printed on it, but
> > still...
>
> I would stick to h616, since we use that for all the other devices. Also
> the H616 *has* that NMI controller: I can confirm that the registers exist,
> and I can trigger and acknowledge interrupts. So in the interest of
> consistency: keep using "allwinner,sun50i-h616-nmi".
>
> Cheers,
> Andre
Okay, and I'll just resubmit then with the notes you mentioned and
your tags.
Thank you.
prev parent reply other threads:[~2024-04-18 17:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 17:04 [PATCH 0/2] Allwinner H616 NMI Controller Chris Morgan
2024-04-14 17:04 ` [PATCH 1/2] dt-bindings: irq: sun7i-nmi: Add binding for the H616 NMI controller Chris Morgan
2024-04-14 22:40 ` Andre Przywara
2024-04-14 17:04 ` [PATCH 2/2] arm64: dts: allwinner: h616: Add NMI device node Chris Morgan
2024-04-14 23:37 ` Andre Przywara
2024-04-18 15:59 ` Chris Morgan
2024-04-18 16:19 ` Andre Przywara
2024-04-18 17:52 ` Chris Morgan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR05MB9229EECD9B39729F8DE0F786A50E2@DM4PR05MB9229.namprd05.prod.outlook.com \
--to=macromorgan@hotmail.com \
--cc=andre.przywara@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=macroalpha82@gmail.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=ryan@testtoast.com \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).