From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Corentin Labbe <clabbe@baylibre.com>,
Maxime Ripard <mripard@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] arm: dts: allwinner: drop underscore in node names
Date: Wed, 24 Apr 2024 06:41:56 +0200 [thread overview]
Message-ID: <1d2412d5-a05d-4d1e-8d50-53a068b90931@linaro.org> (raw)
In-Reply-To: <CAL_JsqJfT-jui5P56CO4Fr37kr5iNN8dpxt8ecKeFmdVGnRYbA@mail.gmail.com>
On 23/04/2024 23:23, Rob Herring wrote:
> On Sun, Mar 17, 2024 at 1:41 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> Underscores should not be used in node names (dtc with W=2 warns about
>> them), so replace them with hyphens. Use also generic name for pwrseq
>> node, because generic naming is favored by Devicetree spec. All the
>> clocks affected by this change use clock-output-names, so resulting
>> clock name should not change. Functional impact checked with comparing
>> before/after DTBs with dtx_diff and fdtdump.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> This adds warnings:
>
> 13 prcm@1f01400: 'ahb0-clk', 'apb0-clk', 'apb0-gates-clk',
> 'apb0-rst', 'ar100-clk', 'ir-clk' do not match any of the regexes:
> '^.*_(clk|rst)$', 'pinctrl-[0-9]+'
>
> Since we documented it with underscores, I'd say just leave these at
> least until if/when we define some standard names. I'd prefer we spend
> time reducing warnings from the common schema. I'm looking at
> root-node.yaml. simple-bus.yaml generates a lot too.
Uh, this was already picked up. I will send patch for schema, thanks for
the report.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-24 4:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-17 18:41 [PATCH 1/4] arm64: dts: allwinner: Pine H64: correctly remove reg_gmac_3v3 Krzysztof Kozlowski
2024-03-17 18:41 ` [PATCH 2/4] arm64: dts: allwinner: drop underscore in node names Krzysztof Kozlowski
2024-03-21 23:59 ` Andre Przywara
2024-03-26 22:18 ` Jernej Škrabec
2024-03-17 18:41 ` [PATCH 3/4] arm64: dts: allwinner: Orange Pi: delete node by phandle Krzysztof Kozlowski
2024-03-17 18:42 ` Krzysztof Kozlowski
2024-03-26 22:19 ` Jernej Škrabec
2024-03-17 18:41 ` [PATCH 4/4] arm: dts: allwinner: drop underscore in node names Krzysztof Kozlowski
2024-03-26 22:21 ` Jernej Škrabec
2024-04-23 21:23 ` Rob Herring
2024-04-24 4:41 ` Krzysztof Kozlowski [this message]
2024-03-18 11:50 ` [PATCH 1/4] arm64: dts: allwinner: Pine H64: correctly remove reg_gmac_3v3 Andre Przywara
2024-03-26 22:16 ` Jernej Škrabec
2024-04-15 21:10 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d2412d5-a05d-4d1e-8d50-53a068b90931@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=clabbe@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).