From: Dan Carpenter <dan.carpenter@linaro.org>
To: Shahar Avidar <ikobh7@gmail.com>
Cc: gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl,
andriy.shevchenko@linux.intel.com, robh@kernel.org,
felixkimbu1@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: pi433: Rename goto label.
Date: Thu, 2 May 2024 11:59:14 +0300 [thread overview]
Message-ID: <752171bd-9695-44f2-aad0-c8140e5099dc@moroto.mountain> (raw)
In-Reply-To: <b0cd37c3-5465-467d-8074-67fa2fddcc4d@gmail.com>
On Thu, May 02, 2024 at 11:44:15AM +0300, Shahar Avidar wrote:
> On 01/05/2024 17:06, Dan Carpenter wrote:
> > On Wed, May 01, 2024 at 08:58:20AM +0300, Shahar Avidar wrote:
> > > Use destroy_class_and_remove_dbfs instead of unreg_class_and_remove_dbfs.
> > >
> > > Signed-off-by: Shahar Avidar <ikobh7@gmail.com>
> > > ---
> > > drivers/staging/pi433/pi433_if.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> > > index c8c1d296184b..4fffd7007040 100644
> > > --- a/drivers/staging/pi433/pi433_if.c
> > > +++ b/drivers/staging/pi433/pi433_if.c
> > > @@ -1409,11 +1409,11 @@ static int __init pi433_init(void)
> > > status = spi_register_driver(&pi433_spi_driver);
> > > if (status < 0)
> > > - goto unreg_class_and_remove_dbfs;
> > > + goto destroy_class_and_remove_dbfs;
> > > return 0;
> > > -unreg_class_and_remove_dbfs:
> > > +destroy_class_and_remove_dbfs:
> > > debugfs_remove(root_dir);
> > > class_destroy(pi433_class);
> >
> > This is cleaning up something which changed in patch 1 so it should have
> > been done in patch 1.
> >
> Thanks for your input.
> I thought of a previous comment you had were you noted Greg preferred small
> patches, so I did my best to keep the first patch the with minimum changes
> without breaking git digest.
The rule is not "as small as possible", it's "one thing per patch".
It's a bit subtle, but you're doing half a thing in this patch. Not a
huge deal. It's part of the learning process.
regards,
dan carpenter
prev parent reply other threads:[~2024-05-02 8:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 5:58 [PATCH 0/2] staging: pi433: Use class_create API Shahar Avidar
2024-05-01 5:58 ` [PATCH 1/2] staging: pi433: Use class_create instead of class_register Shahar Avidar
2024-05-01 14:00 ` Dan Carpenter
2024-05-01 14:14 ` Greg KH
2024-05-02 8:51 ` Shahar Avidar
2024-05-01 14:12 ` Greg KH
2024-05-02 8:40 ` Shahar Avidar
2024-05-02 8:54 ` Greg KH
2024-05-01 5:58 ` [PATCH 2/2] staging: pi433: Rename goto label Shahar Avidar
2024-05-01 14:06 ` Dan Carpenter
2024-05-02 8:44 ` Shahar Avidar
2024-05-02 8:59 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=752171bd-9695-44f2-aad0-c8140e5099dc@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=felixkimbu1@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=ikobh7@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).