From: Dan Carpenter <dan.carpenter@linaro.org>
To: TaheraFahimi <fahimitahera@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: gdm724x: Align descendant argument to the open parenthesis
Date: Tue, 2 Apr 2024 09:49:51 +0300 [thread overview]
Message-ID: <56072f1a-6cca-4c11-9fbd-4081387afdfc@moroto.mountain> (raw)
In-Reply-To: <ZgXupx0nXwIOjy7F@tahera-OptiPlex-5000>
On Thu, Mar 28, 2024 at 04:26:47PM -0600, TaheraFahimi wrote:
> Mute the following checkpatch error:
> CHECK: Alignment should match open parenthesis
It's not aligned either before or after. It should have been:
[tab][tab][tab][tab][tab][space][space][space][space][space][space]TTY_DRIVER_...
>
> Signed-off-by: Tahera Fahimi <fahimitahera@gmail.com>
> ---
> drivers/staging/gdm724x/gdm_tty.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index 15c246d3b1a3..bd80cd48fb44 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -272,8 +272,8 @@ int register_lte_tty_driver(void)
> int ret;
>
> for (i = 0; i < TTY_MAX_COUNT; i++) {
> - tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> - TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
> + tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
> + TTY_DRIVER_DYNAMIC_DEV);
"TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV" goes together. Don't
split that up over two lines. Checkpatch is a tool which is supposed to
help readability. It's not a ruler which must be obeyed. If checkpatch
tells you to do something which makes the code less readable then just
ignore it.
regards,
dan carpenter
prev parent reply other threads:[~2024-04-02 6:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 22:26 [PATCH] staging: gdm724x: Align descendant argument to the open parenthesis TaheraFahimi
2024-03-28 22:51 ` Alison Schofield
2024-04-02 6:49 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56072f1a-6cca-4c11-9fbd-4081387afdfc@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=fahimitahera@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).