From: Shahar Avidar <ikobh7@gmail.com>
To: gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl,
andriy.shevchenko@linux.intel.com, robh@kernel.org,
felixkimbu1@gmail.com
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/6] staging: pi433: Remove duplicated code using the "goto" error recovery scheme.
Date: Tue, 2 Apr 2024 14:14:08 +0300 [thread overview]
Message-ID: <20240402111414.871089-1-ikobh7@gmail.com> (raw)
This patchset improves readability & maintainability:
- Rename device related vars.
- Update pi433_receive param type.
- Remove duplicated code in pi433_init.
v2->v1:
Followed by Dan Carpenter's <dan.carpenter@linaro.org> comments:
- Remove empty "fail" goto tag.
- Reorder pi433 init & exit calls so they have reverse order.
- Add "unreg_spi_drv" goto tag.
- Check "debugfs_create_dir" return value.
- Update "if" statments for consistency.
- Rename pi433_init return var to the more common used "ret".
Shahar Avidar (6):
staging: pi433: Rename struct pi433_device buffer field to tx_buffer.
staging: pi433: Rename struct pi433_device instances to pi433.
staging: pi433: Replace pi433_receive param void type to struct
pi433_device.
staging: pi433: Rename "pi433_dev" of type "dev_t" to "pi433_devt"
staging: pi433: Remove duplicated code using the "goto" error recovery
scheme.
staging: pi433: Rename return value from "status" to "ret".
drivers/staging/pi433/pi433_if.c | 710 ++++++++++++++++---------------
1 file changed, 358 insertions(+), 352 deletions(-)
base-commit: 20952655235dd9b1447829591774f1d8561f7c6a
prerequisite-patch-id: 91943193af2fea74182be67fb583235a3fbeb77b
prerequisite-patch-id: 2cad031ba6a0782a67ab1645ff034a8be65c2e76
prerequisite-patch-id: 1a852ed8f9d133aec7c651fd9007e59e39c55fb7
--
2.34.1
next reply other threads:[~2024-04-02 11:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 11:14 Shahar Avidar [this message]
2024-04-02 11:14 ` [PATCH v2 1/6] staging: pi433: Rename struct pi433_device buffer field to tx_buffer Shahar Avidar
2024-04-02 11:14 ` [PATCH v2 2/6] staging: pi433: Rename struct pi433_device instances to pi433 Shahar Avidar
2024-04-02 11:14 ` [PATCH v2 3/6] staging: pi433: Replace pi433_receive param void type to struct pi433_device Shahar Avidar
2024-04-02 11:14 ` [PATCH v2 4/6] staging: pi433: Rename "pi433_dev" of type "dev_t" to "pi433_devt" Shahar Avidar
2024-04-02 11:14 ` [PATCH v2 5/6] staging: pi433: Remove duplicated code using the "goto" error recovery scheme Shahar Avidar
2024-04-02 16:46 ` Dan Carpenter
2024-04-05 7:46 ` Shahar Avidar
2024-04-02 11:14 ` [PATCH v2 6/6] staging: pi433: Rename return value from "status" to "ret" Shahar Avidar
2024-04-02 16:50 ` Dan Carpenter
2024-04-05 7:47 ` Shahar Avidar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402111414.871089-1-ikobh7@gmail.com \
--to=ikobh7@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=felixkimbu1@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).