From: Shahar Avidar <ikobh7@gmail.com>
To: gregkh@linuxfoundation.org, elder@linaro.org,
andriy.shevchenko@linux.intel.com, robh@kernel.org,
parthiban.veerasooran@microchip.com
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v3 3/3] staging: pi433: Make use of spi mode macro instead of magic number.
Date: Wed, 27 Mar 2024 21:10:04 +0200 [thread overview]
Message-ID: <20240327191004.619748-4-ikobh7@gmail.com> (raw)
In-Reply-To: <20240327191004.619748-1-ikobh7@gmail.com>
Use SPI_MODE_0 to setup spi mode.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Shahar Avidar <ikobh7@gmail.com>
---
v2->v3:
Restore Reviewed-by tag.
drivers/staging/pi433/pi433_if.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index ec9f07a4f769..8c513ac62156 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -1164,7 +1164,7 @@ static int pi433_probe(struct spi_device *spi)
struct dentry *entry;
/* setup spi parameters */
- spi->mode = 0x00;
+ spi->mode = SPI_MODE_0;
spi->bits_per_word = 8;
/*
* spi->max_speed_hz = 10000000;
--
2.34.1
prev parent reply other threads:[~2024-03-27 19:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 19:10 [PATCH v3 0/3] staging: pi433: Fix includes, comments & macros Shahar Avidar
2024-03-27 19:10 ` [PATCH v3 1/3] staging: pi433: Use headers in appropriate files Shahar Avidar
2024-03-27 19:10 ` [PATCH v3 2/3] staging: pi433: Remove an inaccurate comment Shahar Avidar
2024-03-27 19:10 ` Shahar Avidar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240327191004.619748-4-ikobh7@gmail.com \
--to=ikobh7@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=elder@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).