From: Greg KH <gregkh@linuxfoundation.org>
To: Ayush Tiwari <ayushtiw0110@gmail.com>
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8712: Fix instances of lines ending with '('
Date: Mon, 25 Mar 2024 19:35:46 +0100 [thread overview]
Message-ID: <2024032546-earthworm-ardently-ed12@gregkh> (raw)
In-Reply-To: <ZgG6UC1Fiac7pDfa@ayush-HP-Pavilion-Gaming-Laptop-15-ec0xxx>
On Mon, Mar 25, 2024 at 11:24:24PM +0530, Ayush Tiwari wrote:
> Fix instances of lines ending with '(' to address checkpatch warning
> "lines should not add with a '(' " and conform to common kernel coding
> style.
>
> Signed-off-by: Ayush Tiwari <ayushtiw0110@gmail.com>
> ---
> drivers/staging/rtl8712/rtl871x_ioctl_rtl.h | 123 +++++++-------------
> 1 file changed, 41 insertions(+), 82 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_rtl.h b/drivers/staging/rtl8712/rtl871x_ioctl_rtl.h
> index 7c0b880ac686..70d48e6b4112 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_rtl.h
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_rtl.h
> @@ -18,92 +18,51 @@
> #include "drv_types.h"
>
> /*************** oid_rtl_seg_01_01 **************/
> -uint oid_rt_get_signal_quality_hdl(
> - struct oid_par_priv *poid_par_priv);/*84*/
> -uint oid_rt_get_small_packet_crc_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_middle_packet_crc_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_large_packet_crc_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_tx_retry_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_rx_retry_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_rx_total_packet_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_tx_beacon_ok_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_tx_beacon_err_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_rx_icv_err_hdl(
> - struct oid_par_priv *poid_par_priv);/*93*/
> -uint oid_rt_set_encryption_algorithm_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_preamble_mode_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_ap_ip_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_channelplan_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_set_channelplan_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_set_preamble_mode_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_set_bcn_intvl_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_dedicate_probe_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_total_tx_bytes_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_total_rx_bytes_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_current_tx_power_level_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_enc_key_mismatch_count_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_enc_key_match_count_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_channel_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_hardware_radio_off_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_key_mismatch_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_supported_wireless_mode_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_channel_list_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_scan_in_progress_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_forced_data_rate_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_wireless_mode_for_scan_list_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_get_bss_wireless_mode_hdl(
> - struct oid_par_priv *poid_par_priv);
> -uint oid_rt_scan_with_magic_packet_hdl(
> - struct oid_par_priv *poid_par_priv);
> +uint oid_rt_get_signal_quality_hdl(struct oid_par_priv *poid_par_priv); /*84*/
> +uint oid_rt_get_small_packet_crc_hdl(struct oid_par_priv *poid_par_priv);
<snip>
Why are you keeping these functions that no one calls around at all?
Why not remove the ones that are not needed, and then, after cleaning
that all up, then worry about the few that are left to get into proper
shape here.
I would bet most of these aren't needed at all, right?
thanks,
greg k-h
prev parent reply other threads:[~2024-03-25 18:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 17:54 [PATCH] staging: rtl8712: Fix instances of lines ending with '(' Ayush Tiwari
2024-03-25 18:35 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024032546-earthworm-ardently-ed12@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=ayushtiw0110@gmail.com \
--cc=florian.c.schilhabel@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).