From: Umang Jain <umang.jain@ideasonboard.com>
To: linux-staging@lists.linux.dev
Cc: Stefan Wahren <stefan.wahren@i2se.com>,
Dan Carpenter <error27@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Phil Elwell <phil@raspberrypi.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Umang Jain <umang.jain@ideasonboard.com>
Subject: [PATCH 0/3] staging: vc04_services: Drop remaining global members
Date: Tue, 12 Mar 2024 04:46:04 +0530 [thread overview]
Message-ID: <20240311231607.124491-1-umang.jain@ideasonboard.com> (raw)
This series works to drop the remaining (non-essential) global members
in vchiq_connected.[ch] and address the following TODO:
```
* Get rid of all non essential global structures and create a proper per
device structure
```
The global members tracks the connections to the vchiq platform driver.
The logic has been moved to wrap all this within the platform driver
data instead so it can be get()ed whenever necessary.
The user of vchiq_connected.[ch] is not present currently, but the user
will be present when we will upstream bcm2835-isp via the vc-sm-cma
driver. Posting a branch for reference [1] to provide and test the idea
behind this series.
[1]: https://git.uk.ideasonboard.com/uajain/linux/commits/branch/uajain/remove-global
Umang Jain (3):
staging: vc04_services: Move struct vchiq_drvdata to vchiq_core header
staging: v04_services: Add connection structure to driver data
staging: vc04_services: Drop global members for tracking connections
drivers/staging/vc04_services/interface/TODO | 8 ----
.../interface/vchiq_arm/vchiq_arm.c | 18 +++++---
.../interface/vchiq_arm/vchiq_connected.c | 44 +++++++++----------
.../interface/vchiq_arm/vchiq_connected.h | 16 ++++++-
.../interface/vchiq_arm/vchiq_core.h | 9 ++++
5 files changed, 55 insertions(+), 40 deletions(-)
--
2.43.0
next reply other threads:[~2024-03-11 23:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 23:16 Umang Jain [this message]
2024-03-11 23:16 ` [PATCH 1/3] staging: vc04_services: Move struct vchiq_drvdata to vchiq_core header Umang Jain
2024-03-11 23:16 ` [PATCH 2/3] staging: v04_services: Add connection structure to driver data Umang Jain
2024-03-13 5:28 ` Dan Carpenter
2024-03-11 23:16 ` [PATCH 3/3] staging: vc04_services: Drop global members for tracking connections Umang Jain
2024-03-13 5:31 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311231607.124491-1-umang.jain@ideasonboard.com \
--to=umang.jain@ideasonboard.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=error27@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-staging@lists.linux.dev \
--cc=phil@raspberrypi.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).