From: Dorine Tipo <dorine.a.tipo@gmail.com>
To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
outreachy@lists.linux.dev
Cc: Dorine Tipo <dorine.a.tipo@gmail.com>
Subject: [PATCH v7] staging: vt6655: Match open parentheses in card.c
Date: Tue, 5 Mar 2024 21:04:06 +0000 [thread overview]
Message-ID: <20240305210406.29644-1-dorine.a.tipo@gmail.com> (raw)
Align the function parameters to silence a checkpatch warning.
This patch aligns parameters in functions calculate_ofdmr_parameter(),
card_set_phy_parameter(), card_update_tsf() and card_get_tsf_offset(),
for better readability.
Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
Changelog:
V2: Modified subjects to be unique for each patch, as requested by
<gregkh@linuxfoundation.org>
Fixed the warnings in the patches as suggested by
<philipp.g.hortmann@gmail.com>
V3: Combined the vt6655 patches into one patch as suggested by
<dan.carpenter@linaro.org>
V4: Removed the multiple signed-off-by as suggested by
<philipp.g.hortmann@gmail.com>
Omitted the cover letter as the changes have been combined into one
patch
Reworked the patch subject to be concise
V5: Fixed the commit message to "Align
the function parameters to silence a checkpatch warning." as
suggested by <dan.carpenter@linaro.org>
V6: Fix trailing white spaces in the patch to silence checkpatch warning
V7: Edited the subject line to include file name as suggested by
<philipp.g.hortmann@gmail.com>
drivers/staging/vt6655/card.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 36183f2a64c1..3f807d898607 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -81,9 +81,9 @@ static void vt6655_mac_set_bb_type(void __iomem *iobase, u32 mask)
* Return Value: none
*/
static void calculate_ofdmr_parameter(unsigned char rate,
- u8 bb_type,
- unsigned char *tx_rate,
- unsigned char *rsv_time)
+ u8 bb_type,
+ unsigned char *tx_rate,
+ unsigned char *rsv_time)
{
switch (rate) {
case RATE_6M:
@@ -288,7 +288,7 @@ bool card_set_phy_parameter(struct vnt_private *priv, u8 bb_type)
* Return Value: none
*/
bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
- u64 bss_timestamp)
+ u64 bss_timestamp)
{
u64 local_tsf;
u64 tsf_offset = 0;
@@ -297,7 +297,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
if (bss_timestamp != local_tsf) {
tsf_offset = card_get_tsf_offset(rx_rate, bss_timestamp,
- local_tsf);
+ local_tsf);
/* adjust TSF, HW's TSF add TSF Offset reg */
tsf_offset = le64_to_cpu(tsf_offset);
iowrite32((u32)tsf_offset, priv->port_offset + MAC_REG_TSFOFST);
@@ -321,7 +321,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
* Return Value: true if succeed; otherwise false
*/
bool card_set_beacon_period(struct vnt_private *priv,
- unsigned short beacon_interval)
+ unsigned short beacon_interval)
{
u64 next_tbtt;
--
2.25.1
next reply other threads:[~2024-03-07 1:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 21:04 Dorine Tipo [this message]
2024-03-07 17:14 ` [PATCH v7] staging: vt6655: Match open parentheses in card.c Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240305210406.29644-1-dorine.a.tipo@gmail.com \
--to=dorine.a.tipo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).