From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] spi: Remove unneded check for orig_nents
Date: Wed, 15 May 2024 17:09:33 -0400 [thread overview]
Message-ID: <d8930bce-6db6-45f4-8f09-8a00fa48e607@notapiano> (raw)
In-Reply-To: <20240507201028.564630-1-andriy.shevchenko@linux.intel.com>
On Tue, May 07, 2024 at 11:10:27PM +0300, Andy Shevchenko wrote:
> Both dma_unmap_sgtable() and sg_free_table() in spi_unmap_buf_attrs()
> have checks for orig_nents against 0. No need to duplicate this.
> All the same applies to other DMA mapping API calls.
>
> Also note, there is no other user in the kernel that does this kind of
> checks.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Hi,
this commit caused a regression which I reported here:
https://lore.kernel.org/all/d3679496-2e4e-4a7c-97ed-f193bd53af1d@notapiano
along with some thoughts on the cause and a possible solution, though I'm not
familiar with this code base at all and would really appreciate any feedback you
may have.
Thanks,
Nícolas
next prev parent reply other threads:[~2024-05-15 21:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 20:10 [PATCH v1 1/1] spi: Remove unneded check for orig_nents Andy Shevchenko
2024-05-08 12:08 ` Mark Brown
2024-05-16 11:28 ` [PATCH] spi: Remove unneeded " Markus Elfring
2024-05-15 21:09 ` Nícolas F. R. A. Prado [this message]
2024-05-16 10:18 ` [PATCH v1 1/1] spi: Remove unneded " Andy Shevchenko
2024-05-16 13:25 ` Andy Shevchenko
2024-05-16 16:25 ` Nícolas F. R. A. Prado
2024-05-16 17:46 ` Andy Shevchenko
2024-05-16 21:11 ` Nícolas F. R. A. Prado
2024-05-17 15:40 ` Andy Shevchenko
2024-05-22 10:03 ` Neil Armstrong
2024-05-22 11:33 ` Andy Shevchenko
2024-05-22 11:53 ` Neil Armstrong
2024-05-22 13:18 ` Neil Armstrong
2024-05-22 14:24 ` Andy Shevchenko
2024-05-22 15:12 ` Nícolas F. R. A. Prado
2024-05-22 15:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8930bce-6db6-45f4-8f09-8a00fa48e607@notapiano \
--to=nfraprado@collabora.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).