From: JiSheng Teoh <jisheng.teoh@starfivetech.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Michal Simek <michal.simek@amd.com>,
Lars-Peter Clausen <lars@metafoo.de>
Cc: Leyfoon Tan <leyfoon.tan@starfivetech.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
EngLee Teh <englee.teh@starfivetech.com>
Subject: RE: [PATCH v2 1/2] spi: spi-cadence: Add optional reset control support
Date: Fri, 3 May 2024 01:20:46 +0000 [thread overview]
Message-ID: <ZQ4PR01MB11549D971962995878D9593EEB1FA@ZQ4PR01MB1154.CHNPR01.prod.partner.outlook.cn> (raw)
In-Reply-To: <b0c9aa87-ae84-4979-b26b-8fd0579c5f08@kernel.org>
> On 02/05/2024 12:47, Ji Sheng Teoh wrote:
> >
> > /* Macros for the SPI controller read/write */ @@ -588,6 +591,16 @@
> > static int cdns_spi_probe(struct platform_device *pdev)
> > goto remove_ctlr;
> > }
> >
> > + xspi->rstc = devm_reset_control_get_optional_exclusive(&pdev->dev, "spi");
> > + if (IS_ERR(xspi->rstc)) {
> > + ret = PTR_ERR(xspi->rstc);
> > + dev_err(&pdev->dev, "Cannot get SPI reset.\n");
>
> Please switch to:
> ret = dev_err_probe()
Ok, will switch to that. Thanks.
next prev parent reply other threads:[~2024-05-03 1:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 10:47 [PATCH v2 0/2] Add optional reset control for Cadence SPI Ji Sheng Teoh
2024-05-02 10:47 ` [PATCH v2 1/2] spi: spi-cadence: Add optional reset control support Ji Sheng Teoh
2024-05-02 14:16 ` Krzysztof Kozlowski
2024-05-03 1:20 ` JiSheng Teoh [this message]
2024-05-02 10:48 ` [PATCH v2 2/2] dt-bindings: spi: spi-cadence: Add optional reset control Ji Sheng Teoh
2024-05-02 12:21 ` Krzysztof Kozlowski
2024-05-02 12:45 ` JiSheng Teoh
2024-05-02 12:48 ` Krzysztof Kozlowski
2024-05-02 12:58 ` JiSheng Teoh
2024-05-02 13:53 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQ4PR01MB11549D971962995878D9593EEB1FA@ZQ4PR01MB1154.CHNPR01.prod.partner.outlook.cn \
--to=jisheng.teoh@starfivetech.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=englee.teh@starfivetech.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).