From: Mark Brown <broonie@kernel.org>
To: Louis Chauvet <louis.chauvet@bootlin.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com,
yen-mei.goh@keysight.com, jeremie.dautheribes@bootlin.com
Subject: Re: [PATCH] spi: omap2-mcspi: Ensure that CS is correctly asserted when switching from MULTI mode to SINGLE mode
Date: Tue, 9 Apr 2024 18:48:14 +0100 [thread overview]
Message-ID: <7a41b650-b135-40cd-bf55-ee4aeea74fe6@sirena.org.uk> (raw)
In-Reply-To: <20240409-fix-omap2-mcspi-v1-1-f2b881ae196d@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 845 bytes --]
On Tue, Apr 09, 2024 at 07:25:33PM +0200, Louis Chauvet wrote:
> The OMAP2 support features a "multi" mode, where the controller
> automatically sets the Chip Select (CS) when necessary. This mode allows
> for shorter delays between CS selection and word content, but the CS is
> always deasserted at the end.
This breaks the build due to updating for modern names, please rebase
and resend:
/build/stage/linux/drivers/spi/spi-omap2-mcspi.c: In function ‘omap2_mcspi_prepare_message’:
/build/stage/linux/drivers/spi/spi-omap2-mcspi.c:1274:17: error: ‘master’ undeclared (first use in this function)
1274 | master->last_cs = -1;
| ^~~~~~
/build/stage/linux/drivers/spi/spi-omap2-mcspi.c:1274:17: note: each undeclared identifier is reported only once for each function it appears in
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-04-09 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 17:25 [PATCH] spi: omap2-mcspi: Ensure that CS is correctly asserted when switching from MULTI mode to SINGLE mode Louis Chauvet
2024-04-09 17:48 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a41b650-b135-40cd-bf55-ee4aeea74fe6@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jeremie.dautheribes@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=louis.chauvet@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yen-mei.goh@keysight.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).